Source/devtools/front_end/ui/ShortcutRegistry.js - Issue 344443003: DevTools: Code fixes for the Closure compiler roll

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/ui/ShortcutRegistry.js

Issue 344443003: DevTools: Code fixes for the Closure compiler roll (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Address comments Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/devtools/front_end/ui/ShortcutRegistry.js

diff --git a/Source/devtools/front_end/ui/ShortcutRegistry.js b/Source/devtools/front_end/ui/ShortcutRegistry.js

index 4b685dd3a9eb2d592891413b3e1058d370ef1f6d..abe497398dc6d1a51c5bdbcfac16ca615ccaca9a 100644

--- a/Source/devtools/front_end/ui/ShortcutRegistry.js

+++ b/Source/devtools/front_end/ui/ShortcutRegistry.js

@@ -101,7 +101,7 @@ WebInspector.ShortcutRegistry.prototype = {

function isPossiblyInputKey()

{

- if (!event || !WebInspector.isBeingEdited(event.target) || /^F\d+|Control|Shift|Alt|Meta|Win|U\+001B$/.test(keyIdentifier))

+ if (!event || !WebInspector.isBeingEdited(/** @type {!Node} */ (event.target)) || /^F\d+|Control|Shift|Alt|Meta|Win|U\+001B$/.test(keyIdentifier))

return false;

if (!keyModifiers)