Fix for provisioning_devices failure on user builds.

Fix for provisioning_devices failure on user builds.

provisioning_devices tries to use "adb shell su" to set content
settings. However, "su" is not available for user builds and
thus provisioning_devices fails for devices with user builds.

This CL fixes this failure by only setting the content settings
when the device has a userdebug build.

BUG=385789
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279873

[klundberg, 2014-06-24 17:11:47]

Armand, this is needed for the S3 perf bot.

[mstrum, 2014-06-24 18:54:36]

https://codereview.chromium.org/344233005/diff/1/build/android/pylib/device_s...
File build/android/pylib/device_settings.py (right):

https://codereview.chromium.org/344233005/diff/1/build/android/pylib/device_s...
build/android/pylib/device_settings.py:41: if
device.old_interface.GetBuildType() == 'userdebug':
Could you change this to be != 'user' so it works for other variants (e.g. eng)?

[navabi, 2014-06-25 00:27:03]

Is this the only part of provisioning that requires userdebug (i.e. root)?
Adding tonyg who is the author of device_settings.py.

[klundberg, 2014-06-25 15:36:26]

On 2014/06/25 00:27:03, navabi wrote:
> Is this the only part of provisioning that requires userdebug (i.e. root)?

Yes, at least with --skip-wipe. I'm not sure if wiping works at all but we are
not doing that anyway on user builds.

I tested this on a N4 with userdebug, a N4 with user and a S4.

> Adding tonyg who is the author of device_settings.py.

[navabi, 2014-06-25 20:36:55]

lgtm

[navabi1, 2014-06-25 20:37:14]

lgtm

[klundberg, 2014-06-25 20:44:28]

The CQ bit was checked by klundberg@chromium.org

[commit-bot: I haz the power, 2014-06-25 20:46:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/klundberg@chromium.org/344233005/1

[commit-bot: I haz the power, 2014-06-26 00:04:42]

Change committed as 279873