Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: build/android/pylib/device_settings.py

Issue 344233005: Fix for provisioning_devices failure on user builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/device_settings.py
diff --git a/build/android/pylib/device_settings.py b/build/android/pylib/device_settings.py
index 29cf35d1e6283576f70456c8eb9c783aabb8113f..deb673b971dd9e8f9f736e197074a8f656b6f434 100644
--- a/build/android/pylib/device_settings.py
+++ b/build/android/pylib/device_settings.py
@@ -38,13 +38,14 @@ def ConfigureContentSettingsDict(device, desired_settings):
device.old_interface.system_properties['persist.sys.usb.config'] = 'adb'
device.old_interface.WaitForDevicePm()
- for table, key_value in sorted(desired_settings.iteritems()):
- settings = content_settings.ContentSettings(table, device)
- for key, value in key_value.iteritems():
- settings[key] = value
- logging.info('\n%s %s', table, (80 - len(table)) * '-')
- for key, value in sorted(settings.iteritems()):
- logging.info('\t%s: %s', key, value)
+ if device.old_interface.GetBuildType() == 'userdebug':
mstrum 2014/06/24 18:54:35 Could you change this to be != 'user' so it works
+ for table, key_value in sorted(desired_settings.iteritems()):
+ settings = content_settings.ContentSettings(table, device)
+ for key, value in key_value.iteritems():
+ settings[key] = value
+ logging.info('\n%s %s', table, (80 - len(table)) * '-')
+ for key, value in sorted(settings.iteritems()):
+ logging.info('\t%s: %s', key, value)
ENABLE_LOCATION_SETTING = {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698