[Password Manager] Disable saving and filling on sync signup

components/password_manager/core/browser/password_manager_unittest.cc

Index: components/password_manager/core/browser/password_manager_unittest.cc
diff --git a/components/password_manager/core/browser/password_manager_unittest.cc b/components/password_manager/core/browser/password_manager_unittest.cc
index a39038d868e42816463abdd9ae6d177719568105..7abad63a39ade6cda107d08acc0c4b671924abee 100644
--- a/components/password_manager/core/browser/password_manager_unittest.cc
+++ b/components/password_manager/core/browser/password_manager_unittest.cc
@@ -42,6 +42,7 @@ namespace {
 
 class MockPasswordManagerClient : public StubPasswordManagerClient {
  public:
+  MOCK_CONST_METHOD0(IsPasswordManagerEnabledForCurrentPage, bool());
   MOCK_METHOD1(PromptUserToSavePassword, void(PasswordFormManager*));
   MOCK_METHOD0(GetPasswordStore, PasswordStore*());
   MOCK_METHOD0(GetPrefs, PrefService*());
@@ -82,6 +83,8 @@ class PasswordManagerTest : public testing::Test {
     EXPECT_CALL(*store_, ReportMetrics()).Times(AnyNumber());
     CHECK(store_->Init(syncer::SyncableService::StartSyncFlare()));
 
+    EXPECT_CALL(client_, IsPasswordManagerEnabledForCurrentPage())
+        .WillRepeatedly(Return(true));
     EXPECT_CALL(client_, GetPasswordStore()).WillRepeatedly(Return(store_));
     EXPECT_CALL(client_, GetPrefs()).WillRepeatedly(Return(&prefs_));
     EXPECT_CALL(client_, GetDriver()).WillRepeatedly(Return(&driver_));
@@ -617,4 +620,24 @@ TEST_F(PasswordManagerTest, AutofillingNotEnabledOnSSLErrors) {
   manager()->OnPasswordFormsParsed(forms);
 }
 
+TEST_F(PasswordManagerTest, SavingNotEnabledForSyncSignin) {

[vabr (Chromium), 2014/06/24 08:49:49]

The connection between Sync and IsPasswordManagerEnabledForCurrentPage is not
apparent.
My preference would be to replace "SyncSignin", e.g.,
SavingDisabledIfManagerDisabled.
Similarly below.

If you want a test for SyncSignin, that test should indeed attempt to load the
sign-in page. (I'm not sure we need such test.)

+  EXPECT_CALL(client_, IsPasswordManagerEnabledForCurrentPage())
+      .WillRepeatedly(Return(false));
+  EXPECT_FALSE(manager()->IsSavingEnabledForCurrentPage());
+}
+
+TEST_F(PasswordManagerTest, AutofillingNotEnabledForSyncSignin) {
+  EXPECT_CALL(client_, IsPasswordManagerEnabledForCurrentPage())
+      .WillRepeatedly(Return(false));
+
+  // Let us pretend some forms were found on a website.
+  std::vector<PasswordForm> forms;
+  forms.push_back(MakeSimpleForm());
+
+  // Feed those forms to |manager()| and check that it does not try to find
+  // matching saved credentials for the forms.
+  EXPECT_CALL(*store_.get(), GetLogins(_, _, _)).Times(Exactly(0));
+  manager()->OnPasswordFormsParsed(forms);
+}
+
 }  // namespace password_manager