components/password_manager/core/browser/password_manager_client.cc - Issue 344033008: [Password Manager] Disable saving and filling on sync signup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager_client.cc

Issue 344033008: [Password Manager] Disable saving and filling on sync signup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix tests Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/password_manager/core/browser/password_manager.cc ('K') | « components/password_manager/core/browser/password_manager_client.h ('k') | components/password_manager/core/browser/password_manager_unittest.cc » ('j') | components/password_manager/core/browser/password_manager_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_manager_client.cc

diff --git a/components/password_manager/core/browser/password_manager_client.cc b/components/password_manager/core/browser/password_manager_client.cc

index ddadd2d4758e60ad307c5766d99a7313c1e011b2..fe5a7de70360868df303a9d6edb1acf2caf0fc87 100644

--- a/components/password_manager/core/browser/password_manager_client.cc

+++ b/components/password_manager/core/browser/password_manager_client.cc

@@ -10,6 +10,10 @@ bool PasswordManagerClient::IsAutomaticPasswordSavingEnabled() const {

return false;

}

+bool PasswordManagerClient::IsPasswordManagerEnabledForCurrentPage() const {

+ return true;

Roger Tawa OOO till Jul 10th 2014/06/26 14:15:05 Why is the default true? Why is this not pure vir

base::FieldTrial::Probability

PasswordManagerClient::GetProbabilityForExperiment(

const std::string& experiment_name) {