Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 344033002: Remove GCMDriver::IsGCMClientReady (Closed)

Created:
6 years, 6 months ago by jianli
Modified:
6 years, 6 months ago
Reviewers:
fgorski
CC:
chromium-reviews, arv+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Remove GCMDriver::IsGCMClientReady This is not longer used. R=fgorski@chromium.org TBR=arv@chromium.org BUG=none TEST=tests updated Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278526

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -57 lines) Patch
M chrome/browser/resources/gcm_internals.html View 2 chunks +1 line, -8 lines 0 comments Download
M chrome/browser/resources/gcm_internals.js View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/gcm_internals_ui.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/gcm_driver/fake_gcm_driver.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/gcm_driver/fake_gcm_driver.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M components/gcm_driver/gcm_driver.h View 1 chunk +0 lines, -3 lines 0 comments Download
M components/gcm_driver/gcm_driver_android.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/gcm_driver/gcm_driver_android.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M components/gcm_driver/gcm_driver_desktop.h View 2 chunks +0 lines, -4 lines 0 comments Download
M components/gcm_driver/gcm_driver_desktop.cc View 4 chunks +0 lines, -11 lines 0 comments Download
M components/gcm_driver/gcm_driver_desktop_unittest.cc View 8 chunks +0 lines, -18 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jianli
6 years, 6 months ago (2014-06-19 18:30:39 UTC) #1
fgorski
lgtm
6 years, 6 months ago (2014-06-19 21:39:08 UTC) #2
jianli
The CQ bit was checked by jianli@chromium.org
6 years, 6 months ago (2014-06-19 21:41:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jianli@chromium.org/344033002/1
6 years, 6 months ago (2014-06-19 21:43:50 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 6 months ago (2014-06-19 23:19:06 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-19 23:30:21 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/85635)
6 years, 6 months ago (2014-06-19 23:30:22 UTC) #7
jianli
6 years, 6 months ago (2014-06-19 23:44:32 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as r278526 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698