Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Unified Diff: components/gcm_driver/gcm_driver_desktop.cc

Issue 344033002: Remove GCMDriver::IsGCMClientReady (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/gcm_driver/gcm_driver_desktop.h ('k') | components/gcm_driver/gcm_driver_desktop_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/gcm_driver/gcm_driver_desktop.cc
diff --git a/components/gcm_driver/gcm_driver_desktop.cc b/components/gcm_driver/gcm_driver_desktop.cc
index f0f747403258be2553117094aba4cf2ff8df331d..0e7a4e10e70e7f19581246f37b9c63ab19d75cde 100644
--- a/components/gcm_driver/gcm_driver_desktop.cc
+++ b/components/gcm_driver/gcm_driver_desktop.cc
@@ -356,7 +356,6 @@ GCMDriverDesktop::GCMDriverDesktop(
: signed_in_(false),
gcm_started_(false),
gcm_enabled_(true),
- gcm_client_ready_(false),
connected_(false),
ui_thread_(ui_thread),
io_thread_(io_thread),
@@ -552,11 +551,6 @@ bool GCMDriverDesktop::IsStarted() const {
return gcm_started_;
}
-bool GCMDriverDesktop::IsGCMClientReady() const {
- DCHECK(ui_thread_->RunsTasksOnCurrentThread());
- return gcm_client_ready_;
-}
-
bool GCMDriverDesktop::IsConnected() const {
return connected_;
}
@@ -626,7 +620,6 @@ void GCMDriverDesktop::RemoveCachedData() {
weak_ptr_factory_.InvalidateWeakPtrs();
gcm_started_ = false;
- gcm_client_ready_ = false;
delayed_task_controller_.reset();
ClearCallbacks();
}
@@ -668,10 +661,6 @@ void GCMDriverDesktop::MessageSendError(
void GCMDriverDesktop::GCMClientReady() {
DCHECK(ui_thread_->RunsTasksOnCurrentThread());
- if (gcm_client_ready_)
- return;
- gcm_client_ready_ = true;
-
delayed_task_controller_->SetReady();
}
« no previous file with comments | « components/gcm_driver/gcm_driver_desktop.h ('k') | components/gcm_driver/gcm_driver_desktop_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698