content/browser/renderer_host/media/video_capture_host_unittest.cc - Issue 34393006: Refactor MediaStreamManager to never output real device id. It now always output sourceId in the fo…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/media/video_capture_host_unittest.cc

Issue 34393006: Refactor MediaStreamManager to never output real device id. It now always output sourceId in the fo… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix broken video_capture_host unittests. Addressed justinlinlins comments. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/media/media_stream_manager.cc ('K') | « content/browser/renderer_host/media/media_stream_ui_proxy_unittest.cc ('k') | content/public/common/media_stream_request.h » ('j') | content/public/common/media_stream_request.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/media/video_capture_host_unittest.cc

diff --git a/content/browser/renderer_host/media/video_capture_host_unittest.cc b/content/browser/renderer_host/media/video_capture_host_unittest.cc

index f57cfdbf06d6023197f8a6222d41713e61b95c51..3189d2c8936851b1cf6c978589ba4386d199c573 100644

--- a/content/browser/renderer_host/media/video_capture_host_unittest.cc

+++ b/content/browser/renderer_host/media/video_capture_host_unittest.cc

@@ -270,15 +270,13 @@ class VideoCaptureHostTest : public testing::Test {

// Release the reference to the mock object. The object will be destructed

// on the current message loop.

host_ = NULL;

- media_stream_manager_->WillDestroyCurrentMessageLoop();

}

void OpenSession() {

const int render_process_id = 1;

const int render_view_id = 1;

const int page_request_id = 1;

- const GURL security_origin;

+ const GURL security_origin("http://test.com");

ASSERT_TRUE(opened_device_label_.empty());