content/public/common/media_stream_request.cc - Issue 34393006: Refactor MediaStreamManager to never output real device id. It now always output sourceId in the fo…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/common/media_stream_request.cc

Issue 34393006: Refactor MediaStreamManager to never output real device id. It now always output sourceId in the fo… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix broken video_capture_host unittests. Addressed justinlinlins comments. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/media/media_stream_manager.cc ('K') | « content/public/common/media_stream_request.h ('k') | content/renderer/media/media_stream_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/common/media_stream_request.cc

diff --git a/content/public/common/media_stream_request.cc b/content/public/common/media_stream_request.cc

index 738874e09756c2f8db65bd56044fc7681e0bd162..121438bc786d0dc22e99cc1f02ef74173e0ae050 100644

--- a/content/public/common/media_stream_request.cc

+++ b/content/public/common/media_stream_request.cc

@@ -62,7 +62,6 @@ MediaStreamRequest::MediaStreamRequest(

int render_process_id,

int render_view_id,

int page_request_id,

- const std::string& tab_capture_device_id,

const GURL& security_origin,

MediaStreamRequestType request_type,

const std::string& requested_audio_device_id,

@@ -72,7 +71,7 @@ MediaStreamRequest::MediaStreamRequest(

: render_process_id(render_process_id),

render_view_id(render_view_id),

page_request_id(page_request_id),

- tab_capture_device_id(tab_capture_device_id),

+ tab_capture_device_id(),

tommi (sloooow) - chröme 2013/10/28 13:48:23 remove?

perkj_chrome 2013/10/29 08:52:17 Done.

security_origin(security_origin),

request_type(request_type),

requested_audio_device_id(requested_audio_device_id),