Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Unified Diff: Source/bindings/v8/V8Utilities.cpp

Issue 34393005: IDL compiler: merge and simplify EventHandler non-callable value check (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Comment (reupload) Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/V8EventListenerList.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/V8Utilities.cpp
diff --git a/Source/bindings/v8/V8Utilities.cpp b/Source/bindings/v8/V8Utilities.cpp
index 71d7493b164bbc2aeb7128e7b8b2535ecaa7da6e..a395021305069b9835a6aa02c8ad4630434dd749 100644
--- a/Source/bindings/v8/V8Utilities.cpp
+++ b/Source/bindings/v8/V8Utilities.cpp
@@ -149,10 +149,8 @@ void transferHiddenDependency(v8::Handle<v8::Object> object, EventListener* oldV
removeHiddenDependency(object, oldListenerObject, cacheIndex, isolate);
}
}
- // Non-callable input should be treated as null
- if (!newValue->IsNull() && !newValue->IsFunction())
- newValue = v8::Null(isolate);
- if (!newValue->IsNull() && !newValue->IsUndefined())
+ // Non-callable input is treated as null and ignored
+ if (newValue->IsFunction())
createHiddenDependency(object, newValue, cacheIndex, isolate);
}
« no previous file with comments | « Source/bindings/v8/V8EventListenerList.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698