Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Unified Diff: Source/bindings/v8/V8EventListenerList.cpp

Issue 34393005: IDL compiler: merge and simplify EventHandler non-callable value check (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Comment (reupload) Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/V8EventListenerList.h ('k') | Source/bindings/v8/V8Utilities.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/V8EventListenerList.cpp
diff --git a/Source/bindings/v8/V8EventListenerList.cpp b/Source/bindings/v8/V8EventListenerList.cpp
index c37eeb5a0c6aa8cae8ad355494ae3b0fb02f2fd8..59630f46bfe558acdcd0ea542dd03171fdabd151 100644
--- a/Source/bindings/v8/V8EventListenerList.cpp
+++ b/Source/bindings/v8/V8EventListenerList.cpp
@@ -43,8 +43,12 @@ PassRefPtr<EventListener> V8EventListenerList::getEventListener(v8::Local<v8::Va
if (context.IsEmpty())
return 0;
v8::Isolate* isolate = context->GetIsolate();
- if (lookup == ListenerFindOnly)
- return V8EventListenerList::findWrapper(value, isAttribute, isolate);
+ if (lookup == ListenerFindOnly) {
+ // Used by EventTarget::removeEventListener, specifically
+ // EventTargetV8Internal::removeEventListenerMethod
+ ASSERT(!isAttribute);
+ return V8EventListenerList::findWrapper(value, isolate);
+ }
if (V8DOMWrapper::isWrapperOfType(toInnerGlobalObject(context), &V8Window::info))
return V8EventListenerList::findOrCreateWrapper<V8EventListener>(value, isAttribute, isolate);
return V8EventListenerList::findOrCreateWrapper<V8WorkerGlobalScopeEventListener>(value, isAttribute, isolate);
« no previous file with comments | « Source/bindings/v8/V8EventListenerList.h ('k') | Source/bindings/v8/V8Utilities.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698