Issue 343813002: Explicitly compare FontVariant to enumerators.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 343813002: Explicitly compare FontVariant to enumerators. (Closed)

Created:
6 years, 6 months ago by jbroman

Modified:
6 years, 6 months ago

Reviewers:
leviw_travelin_and_unemployed, eae

CC:
blink-reviews, jamesr, blink-reviews-rendering, krit, zoltan1, eae+blinkwatch, leviw+renderwatch, jbroman, danakj, Rik, jchaffraix+rendering, pdr., rwlbuis, Stephen Chennney, rune+blink

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Explicitly compare FontVariant to enumerators. It's a little opaque to say "if (fontDescription.variant())". Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176472

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -6 lines)			Patch
M	Source/core/rendering/RenderText.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/platform/fonts/Font.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/platform/fonts/WidthIterator.cpp	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	Source/platform/fonts/harfbuzz/HarfBuzzShaper.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/platform/fonts/mac/ComplexTextController.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

jbroman

Treating FontVariant as a boolean is a little difficult to read. PTAL.

6 years, 6 months ago (2014-06-18 23:01:20 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/343813002/1

6 years, 6 months ago (2014-06-19 00:20:00 UTC) #4

Message was sent while issue was closed.

Change committed as 176472

Expand Messages | Collapse Messages