Source/platform/fonts/Font.cpp - Issue 343813002: Explicitly compare FontVariant to enumerators.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/fonts/Font.cpp

Issue 343813002: Explicitly compare FontVariant to enumerators. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/fonts/Font.cpp

diff --git a/Source/platform/fonts/Font.cpp b/Source/platform/fonts/Font.cpp

index 848251467a954e367f050dfb898d9882f213dfa9..4eed4a5f26d8b95605d31eb2525c93ca2937b056 100644

--- a/Source/platform/fonts/Font.cpp

+++ b/Source/platform/fonts/Font.cpp

@@ -396,7 +396,7 @@ std::pair<GlyphData, GlyphPage*> Font::glyphDataAndPageForCharacter(UChar32 c, b

ASSERT(isMainThread());

if (variant == AutoVariant) {

- if (m_fontDescription.variant() && !primaryFont()->isSVGFont()) {

+ if (m_fontDescription.variant() == FontVariantSmallCaps && !primaryFont()->isSVGFont()) {

UChar32 upperC = toUpper(c);

if (upperC != c) {

c = upperC;

« no previous file with comments | « Source/core/rendering/RenderText.cpp ('k') | Source/platform/fonts/WidthIterator.cpp » ('j') | no next file with comments »