Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 343593002: Include HTMLFrameOwnerElement.h in fewer headers (Closed)

Created:
6 years, 6 months ago by philipj_slow
Modified:
6 years, 6 months ago
Reviewers:
adamk, eseidel
CC:
blink-reviews, blink-reviews-html_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, rwlbuis
Project:
blink
Visibility:
Public.

Description

Include HTMLFrameOwnerElement.h in fewer headers Because HTMLFrameOwnerElement.h includes Document.h, the consequence is mostly that Document.h includes need to be added. Locally, this reduces the number of recompilation steps when touching HTMLFrameOwnerElement.h from 579 to 117, and when touching Document.h from 1214 to 1160. There is a risk of performance regressions due to outlining Frame::deprecatedLocalOwner(). Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176433

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -10 lines) Patch
M Source/core/dom/ChildFrameDisconnector.h View 1 chunk +4 lines, -2 lines 0 comments Download
M Source/core/dom/ChildFrameDisconnector.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/editing/RemoveFormatCommand.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/frame/Frame.h View 3 chunks +2 lines, -7 lines 0 comments Download
M Source/core/frame/Frame.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/html/HTMLLabelElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLNoEmbedElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLNoScriptElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/forms/RadioInputType.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/forms/ValidationMessage.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/ime/InputMethodContext.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/page/SpatialNavigation.h View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/page/SpatialNavigation.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebRemoteFrameImpl.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
philipj_slow
PTAL
6 years, 6 months ago (2014-06-18 15:18:19 UTC) #1
eseidel
lgtm
6 years, 6 months ago (2014-06-18 15:22:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/343593002/1
6 years, 6 months ago (2014-06-18 15:24:20 UTC) #3
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 16:48:00 UTC) #4
Message was sent while issue was closed.
Change committed as 176433

Powered by Google App Engine
This is Rietveld 408576698