Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 343553002: Remove virtual/serviceworker test suite as --enable-service-worker will be removed (Closed)

Created:
6 years, 6 months ago by falken
Modified:
6 years, 6 months ago
Reviewers:
michaeln, jsbell
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, jamesr, tzik, serviceworker-reviews, nhiroki, abarth-chromium, dglazkov+blink, kinuko+serviceworker, horo+watch_chromium.org, alecflett+watch_chromium.org
Project:
blink
Visibility:
Public.

Description

Remove virtual/serviceworker test suite as --enable-service-worker will be removed Service Worker will only be gated by --enable-experimental-web-platform-features, so it will always be enabled in layout tests. BUG=365201

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -196 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +27 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/activation-after-registration-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/controller-on-load-expected.txt View 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/controller-on-reload-expected.txt View 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/fetch-event-expected.txt View 1 chunk +6 lines, -5 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/fetch-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/headermap-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/indexeddb-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/interfaces-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/postmessage-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/postmessage-msgport-to-client-expected.txt View 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/postmessage-to-client-expected.txt View 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/ready-controlled-document-expected.txt View 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/registration-end-to-end-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/registration-events-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/registration-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/request-end-to-end-expected.txt View 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/request-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/response-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/service-worker-gc-expected.txt View 1 chunk +6 lines, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/serviceworkerglobalscope-scope-expected.txt View 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/serviceworkerobject-scope-expected.txt View 1 chunk +9 lines, -9 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/state-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/unregister-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/waiting-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/window-close-during-registration-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/virtual/serviceworker/http/tests/serviceworker/README.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/virtual/serviceworker/http/tests/serviceworker/activation-after-registration-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/virtual/serviceworker/http/tests/serviceworker/controller-on-load-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/virtual/serviceworker/http/tests/serviceworker/controller-on-reload-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/virtual/serviceworker/http/tests/serviceworker/fetch-event-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/virtual/serviceworker/http/tests/serviceworker/fetch-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/virtual/serviceworker/http/tests/serviceworker/headermap-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/virtual/serviceworker/http/tests/serviceworker/indexeddb-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/virtual/serviceworker/http/tests/serviceworker/interfaces-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/virtual/serviceworker/http/tests/serviceworker/postmessage-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/virtual/serviceworker/http/tests/serviceworker/postmessage-msgport-to-client-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/virtual/serviceworker/http/tests/serviceworker/postmessage-to-client-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/virtual/serviceworker/http/tests/serviceworker/ready-controlled-document-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/virtual/serviceworker/http/tests/serviceworker/registration-end-to-end-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/virtual/serviceworker/http/tests/serviceworker/registration-events-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/virtual/serviceworker/http/tests/serviceworker/registration-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D LayoutTests/virtual/serviceworker/http/tests/serviceworker/request-end-to-end-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/virtual/serviceworker/http/tests/serviceworker/request-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/virtual/serviceworker/http/tests/serviceworker/response-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/virtual/serviceworker/http/tests/serviceworker/service-worker-gc-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/virtual/serviceworker/http/tests/serviceworker/serviceworkerglobalscope-scope-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/virtual/serviceworker/http/tests/serviceworker/serviceworkerobject-scope-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/virtual/serviceworker/http/tests/serviceworker/state-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/virtual/serviceworker/http/tests/serviceworker/unregister-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D LayoutTests/virtual/serviceworker/http/tests/serviceworker/waiting-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/virtual/serviceworker/http/tests/serviceworker/window-close-during-registration-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerError.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/base.py View 1 chunk +0 lines, -4 lines 0 comments Download
M public/platform/WebServiceWorkerError.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
falken
This patch must land before https://codereview.chromium.org/339973003/
6 years, 6 months ago (2014-06-18 09:40:03 UTC) #1
jsbell
Can this "before" patch just be a TestExpectations change that marks all of the non-virtual ...
6 years, 6 months ago (2014-06-18 18:04:36 UTC) #2
falken
6 years, 6 months ago (2014-06-19 00:37:04 UTC) #3
On 2014/06/18 18:04:36, jsbell wrote:
> Can this "before" patch just be a TestExpectations change that marks all of
the
> non-virtual tests as [ Pass Fail ]?
> 
> Then the "after" patch can clean up base.py (to stop running the virutal
tests)
> and simply delete *all* of the expectation files -
> https://codereview.chromium.org/328243002 they are not needed any more.

Ohh! I didn't know that. That's great, will do.
(My idea here was to move the expectation files from virtual to non-virtual to
ensure we're not regressing anything.)


> And can the code changes be a separate patch?

Yeah, I should have done that, was just trying to minimize the sides of the
n-sided patch.

Powered by Google App Engine
This is Rietveld 408576698