Issue 343513002: Refactor views::Label and gfx::RenderText shadow functions.

Issue 343513002: Refactor views::Label and gfx::RenderText shadow functions. (Closed)

Created:
6 years, 6 months ago by msw

Modified:
6 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews, tdanderson+overview_chromium.org, kalyank, sadrul, ben+ash_chromium.org, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Refactor views::Label and gfx::RenderText shadow functions. This is mechanical cleanup in preparation for a Label rewrite. Use simple gfx::ShadowValues setter functions everywhere. Remove a forbidden static FontList instance. BUG=240037 TEST=No appearance changes for views text shadows. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278101

Patch Set 1 #

Patch Set 2 : Use simple set_shadows accessors. #

Total comments: 2

Patch Set 3 : Remove forbidden static FontList. #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -83 lines)			Patch
M	ash/system/tray/tray_utils.cc	View	1 2	1 chunk	+3 lines, -8 lines	0 comments	Download
M	ash/touch/touch_hud_debug.cc	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download
M	ash/wm/overview/window_selector_item.cc	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download
M	ui/gfx/canvas_skia.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/gfx/render_text.h	View	1	3 chunks	+4 lines, -5 lines	0 comments	Download
M	ui/gfx/render_text.cc	View	1	3 chunks	+2 lines, -6 lines	0 comments	Download
M	ui/views/controls/button/blue_button.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ui/views/controls/button/label_button.cc	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	ui/views/controls/label.h	View	1	3 chunks	+4 lines, -24 lines	0 comments	Download
M	ui/views/controls/label.cc	View	1	4 chunks	+1 line, -26 lines	0 comments	Download
M	ui/views/examples/label_example.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

sky

https://codereview.chromium.org/343513002/diff/20001/ash/system/tray/tray_utils.cc File ash/system/tray/tray_utils.cc (right): https://codereview.chromium.org/343513002/diff/20001/ash/system/tray/tray_utils.cc#newcode17 ash/system/tray/tray_utils.cc:17: static const gfx::FontList font_list( Style guide says no statics ...

6 years, 6 months ago (2014-06-18 00:04:40 UTC) #2

msw

Please take another look; thanks! https://codereview.chromium.org/343513002/diff/20001/ash/system/tray/tray_utils.cc File ash/system/tray/tray_utils.cc (right): https://codereview.chromium.org/343513002/diff/20001/ash/system/tray/tray_utils.cc#newcode17 ash/system/tray/tray_utils.cc:17: static const gfx::FontList font_list( ...

6 years, 6 months ago (2014-06-18 00:15:27 UTC) #3

sky

"Objects with static storage duration, including global variables, static variables, static class member variables, and ...

6 years, 6 months ago (2014-06-18 03:29:15 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/343513002/40001

6 years, 6 months ago (2014-06-18 04:14:16 UTC) #6

Message was sent while issue was closed.

Change committed as 278101

Expand Messages | Collapse Messages