cc/resources/tile_priority_unittest.cc - Issue 343463004: Move occlusion info to TilePriority.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/resources/tile_priority_unittest.cc

Issue 343463004: Move occlusion info to TilePriority. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address feedback Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/resources/tile_priority_unittest.cc

diff --git a/cc/resources/tile_priority_unittest.cc b/cc/resources/tile_priority_unittest.cc

index e134bc976426c744b46548e593fa3a094882d7c8..10ee245d5a0bc445b48e8644d8a74c06b439bf9d 100644

--- a/cc/resources/tile_priority_unittest.cc

+++ b/cc/resources/tile_priority_unittest.cc

@@ -8,12 +8,14 @@

namespace cc {

TEST(TilePriorityTest, IsHigherPriorityThan) {

- TilePriority now(HIGH_RESOLUTION, TilePriority::NOW, 0);

- TilePriority close_soon(HIGH_RESOLUTION, TilePriority::SOON, 1);

- TilePriority far_soon(HIGH_RESOLUTION, TilePriority::SOON, 500);

- TilePriority close_eventually(HIGH_RESOLUTION, TilePriority::EVENTUALLY, 2);

- TilePriority far_eventually(HIGH_RESOLUTION, TilePriority::EVENTUALLY, 1000);

- TilePriority non_ideal_now(NON_IDEAL_RESOLUTION, TilePriority::NOW, 0);

+ TilePriority now(HIGH_RESOLUTION, false, TilePriority::NOW, 0);

danakj 2014/06/19 19:19:59 Can you add a few cases here to show that occlusio

jbedley 2014/06/19 20:51:20 Done.

+ TilePriority close_soon(HIGH_RESOLUTION, false, TilePriority::SOON, 1);

+ TilePriority far_soon(HIGH_RESOLUTION, false, TilePriority::SOON, 500);

+ TilePriority close_eventually(

+ HIGH_RESOLUTION, false, TilePriority::EVENTUALLY, 2);

+ TilePriority far_eventually(

+ HIGH_RESOLUTION, false, TilePriority::EVENTUALLY, 1000);

+ TilePriority non_ideal_now(NON_IDEAL_RESOLUTION, false, TilePriority::NOW, 0);

EXPECT_FALSE(now.IsHigherPriorityThan(now));

EXPECT_FALSE(now.IsHigherPriorityThan(non_ideal_now));