cc/resources/tile_priority_unittest.cc - Issue 343463004: Move occlusion info to TilePriority.

Side by Side Diff: cc/resources/tile_priority_unittest.cc

Issue 343463004: Move occlusion info to TilePriority. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address feedback Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« cc/resources/picture_layer_tiling.cc ('K') | « cc/resources/tile_priority.h ('k') | cc/test/test_tile_priorities.cc » ('j') | cc/test/test_tile_priorities.cc » ('J')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "cc/resources/tile_priority.h"	5 #include "cc/resources/tile_priority.h"

6 #include "testing/gtest/include/gtest/gtest.h"	6 #include "testing/gtest/include/gtest/gtest.h"

7	7

8 namespace cc {	8 namespace cc {

9	9

10 TEST(TilePriorityTest, IsHigherPriorityThan) {	10 TEST(TilePriorityTest, IsHigherPriorityThan) {

11 TilePriority now(HIGH_RESOLUTION, TilePriority::NOW, 0);	11 TilePriority now(HIGH_RESOLUTION, false, TilePriority::NOW, 0);
	danakj 2014/06/19 19:19:59 Can you add a few cases here to show that occlusio Can you add a few cases here to show that occlusion doesn't change priority? jbedley 2014/06/19 20:51:20 Done. Show quoted text On 2014/06/19 19:19:59, danakj wrote: > Can you add a few cases here to show that occlusion doesn't change priority? Done.
12 TilePriority close_soon(HIGH_RESOLUTION, TilePriority::SOON, 1);	12 TilePriority close_soon(HIGH_RESOLUTION, false, TilePriority::SOON, 1);

13 TilePriority far_soon(HIGH_RESOLUTION, TilePriority::SOON, 500);	13 TilePriority far_soon(HIGH_RESOLUTION, false, TilePriority::SOON, 500);

14 TilePriority close_eventually(HIGH_RESOLUTION, TilePriority::EVENTUALLY, 2);	14 TilePriority close_eventually(

15 TilePriority far_eventually(HIGH_RESOLUTION, TilePriority::EVENTUALLY, 1000);	15 HIGH_RESOLUTION, false, TilePriority::EVENTUALLY, 2);

16 TilePriority non_ideal_now(NON_IDEAL_RESOLUTION, TilePriority::NOW, 0);	16 TilePriority far_eventually(

	17 HIGH_RESOLUTION, false, TilePriority::EVENTUALLY, 1000);

	18 TilePriority non_ideal_now(NON_IDEAL_RESOLUTION, false, TilePriority::NOW, 0);

17	19

18 EXPECT_FALSE(now.IsHigherPriorityThan(now));	20 EXPECT_FALSE(now.IsHigherPriorityThan(now));

19 EXPECT_FALSE(now.IsHigherPriorityThan(non_ideal_now));	21 EXPECT_FALSE(now.IsHigherPriorityThan(non_ideal_now));

20	22

21 EXPECT_TRUE(now.IsHigherPriorityThan(close_soon));	23 EXPECT_TRUE(now.IsHigherPriorityThan(close_soon));

22 EXPECT_TRUE(now.IsHigherPriorityThan(far_soon));	24 EXPECT_TRUE(now.IsHigherPriorityThan(far_soon));

23 EXPECT_TRUE(now.IsHigherPriorityThan(close_eventually));	25 EXPECT_TRUE(now.IsHigherPriorityThan(close_eventually));

24 EXPECT_TRUE(now.IsHigherPriorityThan(far_eventually));	26 EXPECT_TRUE(now.IsHigherPriorityThan(far_eventually));

25 EXPECT_TRUE(close_soon.IsHigherPriorityThan(far_soon));	27 EXPECT_TRUE(close_soon.IsHigherPriorityThan(far_soon));

26 EXPECT_TRUE(close_soon.IsHigherPriorityThan(close_eventually));	28 EXPECT_TRUE(close_soon.IsHigherPriorityThan(close_eventually));

27 EXPECT_TRUE(close_soon.IsHigherPriorityThan(far_eventually));	29 EXPECT_TRUE(close_soon.IsHigherPriorityThan(far_eventually));

28 EXPECT_TRUE(far_soon.IsHigherPriorityThan(close_eventually));	30 EXPECT_TRUE(far_soon.IsHigherPriorityThan(close_eventually));

29 EXPECT_TRUE(far_soon.IsHigherPriorityThan(far_eventually));	31 EXPECT_TRUE(far_soon.IsHigherPriorityThan(far_eventually));

30 EXPECT_TRUE(close_eventually.IsHigherPriorityThan(far_eventually));	32 EXPECT_TRUE(close_eventually.IsHigherPriorityThan(far_eventually));

31	33

32 EXPECT_FALSE(far_eventually.IsHigherPriorityThan(close_eventually));	34 EXPECT_FALSE(far_eventually.IsHigherPriorityThan(close_eventually));

33 EXPECT_FALSE(far_eventually.IsHigherPriorityThan(far_soon));	35 EXPECT_FALSE(far_eventually.IsHigherPriorityThan(far_soon));

34 EXPECT_FALSE(far_eventually.IsHigherPriorityThan(close_soon));	36 EXPECT_FALSE(far_eventually.IsHigherPriorityThan(close_soon));

35 EXPECT_FALSE(far_eventually.IsHigherPriorityThan(now));	37 EXPECT_FALSE(far_eventually.IsHigherPriorityThan(now));

36 EXPECT_FALSE(far_eventually.IsHigherPriorityThan(non_ideal_now));	38 EXPECT_FALSE(far_eventually.IsHigherPriorityThan(non_ideal_now));

37 EXPECT_FALSE(close_eventually.IsHigherPriorityThan(far_soon));	39 EXPECT_FALSE(close_eventually.IsHigherPriorityThan(far_soon));

38 EXPECT_FALSE(close_eventually.IsHigherPriorityThan(close_soon));	40 EXPECT_FALSE(close_eventually.IsHigherPriorityThan(close_soon));

39 EXPECT_FALSE(close_eventually.IsHigherPriorityThan(now));	41 EXPECT_FALSE(close_eventually.IsHigherPriorityThan(now));

40 EXPECT_FALSE(far_soon.IsHigherPriorityThan(close_soon));	42 EXPECT_FALSE(far_soon.IsHigherPriorityThan(close_soon));

41 EXPECT_FALSE(far_soon.IsHigherPriorityThan(now));	43 EXPECT_FALSE(far_soon.IsHigherPriorityThan(now));

42 EXPECT_FALSE(close_soon.IsHigherPriorityThan(now));	44 EXPECT_FALSE(close_soon.IsHigherPriorityThan(now));

43 }	45 }

44	46

45 } // namespace cc	47 } // namespace cc

OLD	NEW