Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(780)

Unified Diff: Source/core/svg/SVGTextPathElement.cpp

Issue 343443003: Remove SVGElement::rendererIsNeeded (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Remove accidently squashed patch Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Source/core/svg/SVGTSpanElement.cpp ('K') | « Source/core/svg/SVGTSpanElement.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGTextPathElement.cpp
diff --git a/Source/core/svg/SVGTextPathElement.cpp b/Source/core/svg/SVGTextPathElement.cpp
index 8c42b33d570485456e7da5375ac6faadee618543..49e1bf137e3cfe5cf689e94d5ecc04168fea9a1f 100644
--- a/Source/core/svg/SVGTextPathElement.cpp
+++ b/Source/core/svg/SVGTextPathElement.cpp
@@ -135,10 +135,12 @@ RenderObject* SVGTextPathElement::createRenderer(RenderStyle*)
bool SVGTextPathElement::rendererIsNeeded(const RenderStyle& style)
{
- if (parentNode() && (isSVGAElement(*parentNode()) || isSVGTextElement(*parentNode())))
- return Element::rendererIsNeeded(style);
+ if (!parentNode() || !(isSVGAElement(*parentNode()) || isSVGTextElement(*parentNode())))
esprehn 2014/06/20 07:58:26 It shouldn't be possible to get in here without a
+ return false;
- return false;
+ if (!isValid())
+ return false;
+ return Element::rendererIsNeeded(style);
}
void SVGTextPathElement::buildPendingResource()
« Source/core/svg/SVGTSpanElement.cpp ('K') | « Source/core/svg/SVGTSpanElement.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698