Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 343343004: [safe browsing] Delete very obsolete histograms, take ownership of others. (Closed)

Created:
6 years, 5 months ago by Scott Hess - ex-Googler
Modified:
6 years, 5 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

[safe browsing] Take ownership of various live histograms. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281970

Patch Set 1 #

Patch Set 2 : Oops, this one still belongs. #

Patch Set 3 : Don't delete the very old histograms after all. #

Patch Set 4 : Rebase and mark obsolete histograms. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -36 lines) Patch
M tools/metrics/histograms/histograms.xml View 38 chunks +75 lines, -36 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Scott Hess - ex-Googler
Random cleanup that's been sitting around on my disk...
6 years, 5 months ago (2014-06-27 22:37:14 UTC) #1
Ilya Sherman
The preference is to mark histograms as <obsolete> rather than deleting them from histograms.xml. Among ...
6 years, 5 months ago (2014-06-27 22:38:21 UTC) #2
Scott Hess - ex-Googler
On 2014/06/27 22:38:21, Ilya Sherman wrote: > The preference is to mark histograms as <obsolete> ...
6 years, 5 months ago (2014-06-27 22:52:45 UTC) #3
Ilya Sherman
On 2014/06/27 22:52:45, shess wrote: > On 2014/06/27 22:38:21, Ilya Sherman wrote: > > The ...
6 years, 5 months ago (2014-06-27 23:01:07 UTC) #4
Scott Hess - ex-Googler
On 2014/06/27 23:01:07, Ilya Sherman wrote: > On 2014/06/27 22:52:45, shess wrote: > > On ...
6 years, 5 months ago (2014-07-08 19:57:04 UTC) #5
Ilya Sherman
LGTM, thanks.
6 years, 5 months ago (2014-07-08 22:34:34 UTC) #6
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 5 months ago (2014-07-08 22:34:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/343343004/60001
6 years, 5 months ago (2014-07-08 22:36:06 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 06:06:42 UTC) #9
Message was sent while issue was closed.
Change committed as 281970

Powered by Google App Engine
This is Rietveld 408576698