Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 343343004: [safe browsing] Delete very obsolete histograms, take ownership of others. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase and mark obsolete histograms. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index feed2d6493d55bdb71b68bf29d5195c3587f53be..c3dbe65a1ea941495d76a5e0e3256a3be8a4b7b7 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -24832,6 +24832,9 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</histogram>
<histogram name="SB.BloomFilter" units="milliseconds">
+ <obsolete>
+ Has not been generated for years (7/8/14).
+ </obsolete>
<owner>Please list the metric's owners. Add more owner tags as needed.</owner>
<summary>
The first stage check that measures the time that Chrome took to check if a
@@ -24848,6 +24851,9 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</histogram>
<histogram name="SB.Database" units="milliseconds">
+ <obsolete>
+ Has not been generated for years (7/8/14).
+ </obsolete>
<owner>Please list the metric's owners. Add more owner tags as needed.</owner>
<summary>
The second stage check that measures the time that Chrome took to check if a
@@ -24856,6 +24862,9 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</histogram>
<histogram name="SB.DBCheck" units="milliseconds">
+ <obsolete>
+ Has not been generated for years (7/8/14).
+ </obsolete>
<owner>Please list the metric's owners. Add more owner tags as needed.</owner>
<summary>
The second stage check that mesures the time that Chrome took to check if a
@@ -24865,6 +24874,9 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</histogram>
<histogram name="SB.Delay" units="milliseconds">
+ <obsolete>
+ Has not been generated for years (7/8/14).
+ </obsolete>
<owner>Please list the metric's owners. Add more owner tags as needed.</owner>
<summary>
This measures the time that SafeBrowsing actually delayed the browsing
@@ -24875,6 +24887,9 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</histogram>
<histogram name="SB.FilterCheck" units="milliseconds">
+ <obsolete>
+ Has not been generated for years (7/8/14).
+ </obsolete>
<owner>Please list the metric's owners. Add more owner tags as needed.</owner>
<summary>
The first stage check that measures the time that Chrome took to check if a
@@ -24883,6 +24898,9 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</histogram>
<histogram name="SB.Network" units="milliseconds">
+ <obsolete>
+ Has not been generated for years (7/8/14).
+ </obsolete>
<owner>Please list the metric's owners. Add more owner tags as needed.</owner>
<summary>
The third and final stage check that mesures the time that Chrome took to
@@ -24891,6 +24909,9 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</histogram>
<histogram name="SB.NetworkCheck" units="milliseconds">
+ <obsolete>
+ Has not been generated for years (7/8/14).
+ </obsolete>
<owner>Please list the metric's owners. Add more owner tags as needed.</owner>
<summary>
The third and final stage check that mesures the time that Chrome took to
@@ -24900,6 +24921,9 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</histogram>
<histogram name="SB.PauseSafe" units="milliseconds">
+ <obsolete>
+ Has not been generated for years (7/8/14).
+ </obsolete>
<owner>Please list the metric's owners. Add more owner tags as needed.</owner>
<summary>
This measures the time that SafeBrowsing actually delayed the browsing
@@ -24910,18 +24934,24 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</histogram>
<histogram name="SB.Update">
+ <obsolete>
+ Has not been generated for years (7/8/14).
+ </obsolete>
<owner>Please list the metric's owners. Add more owner tags as needed.</owner>
<summary>TBD.</summary>
</histogram>
<histogram name="SB2.AddPrefixes">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
+ <owner>shess@chromium.org</owner>
<summary>
The number of add prefixes stored in the database after the last update.
</summary>
</histogram>
<histogram name="SB2.BloomFailure" enum="SB2BloomFailure">
+ <obsolete>
+ Bloom filter support deleted in October 2012.
+ </obsolete>
<owner>Please list the metric's owners. Add more owner tags as needed.</owner>
<summary>
Track failures when in processing the safe-browsing database bloom filter.
@@ -24942,12 +24972,15 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</histogram>
<histogram name="SB2.BloomFilterLoad" units="ms">
+ <obsolete>
+ Bloom filter support deleted in October 2012.
+ </obsolete>
<owner>Please list the metric's owners. Add more owner tags as needed.</owner>
<summary>Time to load the BloomFilter file.</summary>
</histogram>
<histogram name="SB2.BrowseDatabaseKilobytes" units="KB">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
+ <owner>shess@chromium.org</owner>
<summary>
The size of the browsing SafeBrowsing database file on disk in kilobytes,
after an update has occurred.
@@ -24955,7 +24988,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</histogram>
<histogram name="SB2.BuildFilter" units="milliseconds">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
+ <owner>shess@chromium.org</owner>
<summary>
The time that it took to regenerate the filter after we have received all
the update chunks.
@@ -24975,7 +25008,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</histogram>
<histogram name="SB2.BuildReadKilobytes" units="KB">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
+ <owner>shess@chromium.org</owner>
<summary>
The number of kilobytes read by the browser process during the filter
generation phase.
@@ -24983,7 +25016,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</histogram>
<histogram name="SB2.BuildReadOperations">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
+ <owner>shess@chromium.org</owner>
<summary>
The number of read operations issued by the browser process during the
filter generation phase.
@@ -25003,7 +25036,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</histogram>
<histogram name="SB2.BuildWriteKilobytes" units="KB">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
+ <owner>shess@chromium.org</owner>
<summary>
The number of kilobytes written by the browser process during the filter
generation phase.
@@ -25011,7 +25044,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</histogram>
<histogram name="SB2.BuildWriteOperations">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
+ <owner>shess@chromium.org</owner>
<summary>
The number of write operations issued by the browser process during the
filter generation phase.
@@ -25019,7 +25052,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</histogram>
<histogram name="SB2.ChunkInsert" units="milliseconds">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
+ <owner>shess@chromium.org</owner>
<summary>
The time that it takes to write one redirect URL (which can contain multiple
chunks) to the database.
@@ -25027,14 +25060,14 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</histogram>
<histogram name="SB2.ChunkRequest" units="milliseconds">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
+ <owner>shess@chromium.org</owner>
<summary>
The network time between the request and response for a chunk.
</summary>
</histogram>
<histogram name="SB2.ChunkSize" units="bytes">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
+ <owner>shess@chromium.org</owner>
<summary>The size of one chunk URL.</summary>
</histogram>
@@ -25048,7 +25081,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</histogram>
<histogram name="SB2.DatabaseFailure" enum="SB2DatabaseFailure">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
+ <owner>shess@chromium.org</owner>
<summary>Track failures when updating the safe-browsing database.</summary>
</histogram>
@@ -25063,7 +25096,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</histogram>
<histogram name="SB2.DatabaseOpen" units="milliseconds">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
+ <owner>shess@chromium.org</owner>
<summary>
The time it takes to initialize the SafeBrowsing storage backend, in
milliseconds.
@@ -25079,7 +25112,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</histogram>
<histogram name="SB2.Delay" units="milliseconds">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
+ <owner>shess@chromium.org</owner>
<summary>
The time that SafeBrowsing actually delayed the browsing experience. It
records the difference between the time when Chrome would have started
@@ -25105,7 +25138,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</histogram>
<histogram name="SB2.DownloadChecks" enum="SB2DownloadChecks">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
+ <owner>shess@chromium.org</owner>
<summary>
Records results of SafeBrowsing download check, including both url check and
downloaded file hash check.
@@ -25113,7 +25146,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</histogram>
<histogram name="SB2.DownloadDatabaseKilobytes" units="KB">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
+ <owner>shess@chromium.org</owner>
<summary>
The size of the downloads SafeBrowsing database file on disk in kilobytes,
after an update has occurred.
@@ -25121,19 +25154,19 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</histogram>
<histogram name="SB2.DownloadDuration" units="milliseconds">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
+ <owner>shess@chromium.org</owner>
<summary>The time it takes for a download to finish.</summary>
</histogram>
<histogram name="SB2.DownloadHashCheckDuration" units="milliseconds">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
+ <owner>shess@chromium.org</owner>
<summary>
The time it takes for SafeBrowsing to check hash of a download file.
</summary>
</histogram>
<histogram name="SB2.DownloadUrlCheckDuration" units="milliseconds">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
+ <owner>shess@chromium.org</owner>
<summary>The time it takes for SafeBrowsing to check a download url.</summary>
</histogram>
@@ -25166,7 +25199,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</histogram>
<histogram name="SB2.FilterCheck" units="milliseconds">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
+ <owner>shess@chromium.org</owner>
<summary>
The time that it took to check a URL against our in-memory filter.
</summary>
@@ -25181,7 +25214,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</histogram>
<histogram name="SB2.FilterLoad" enum="SB2FilterLoad">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
+ <owner>shess@chromium.org</owner>
<summary>Which filter file the database loaded from disk.</summary>
</histogram>
@@ -25390,7 +25423,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</histogram>
<histogram name="SB2.OldDatabaseKilobytes" units="KB">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
+ <owner>shess@chromium.org</owner>
<summary>Size of v1 database deleted from client profile.</summary>
</histogram>
@@ -25454,7 +25487,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</histogram>
<histogram name="SB2.PrefixSetBitsPerPrefix" units="bits">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
+ <owner>shess@chromium.org</owner>
<summary>
The size of the PrefixSet storage in bits, divided by the number of prefixes
represented. Should almost always be 16.
@@ -25473,12 +25506,12 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</histogram>
<histogram name="SB2.PrefixSetKilobytes" units="KB">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
+ <owner>shess@chromium.org</owner>
<summary>The size of the PrefixSet file in kilobytes.</summary>
</histogram>
<histogram name="SB2.PrefixSetLoad" units="ms">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
+ <owner>shess@chromium.org</owner>
<summary>Time to load the PrefixSet file.</summary>
</histogram>
@@ -25551,7 +25584,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</histogram>
<histogram name="SB2.PrefixSetWrite" units="ms">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
+ <owner>shess@chromium.org</owner>
<summary>Time to store the PrefixSet file.</summary>
</histogram>
@@ -25587,7 +25620,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</histogram>
<histogram name="SB2.SideEffectFreeWhitelistDatabaseKilobytes" units="KB">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
+ <owner>shess@chromium.org</owner>
<summary>
The size of the Side Effect Free Whitelist SaafeBrowsing database file on
disk in kilobytes, after an update has occurred.
@@ -25595,7 +25628,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</histogram>
<histogram name="SB2.SideEffectFreeWhitelistPrefixSetKilobytes" units="KB">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
+ <owner>shess@chromium.org</owner>
<summary>
The size of the Side Effect Free Whitelist PrefixSet file in kilobytes,
after an udpate has occurred.
@@ -25603,12 +25636,12 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</histogram>
<histogram name="SB2.SideEffectFreeWhitelistPrefixSetLoad" units="ms">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
+ <owner>shess@chromium.org</owner>
<summary>Time to load the Side Effect Free Whitelist PrefixSet file.</summary>
</histogram>
<histogram name="SB2.SideEffectFreeWhitelistPrefixSetWrite" units="ms">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
+ <owner>shess@chromium.org</owner>
<summary>
Time to store the Side Effect Free Whitelist PrefixSet file.
</summary>
@@ -25616,7 +25649,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<histogram name="SB2.SideEffectFreeWhitelistStatus"
enum="SB2SideEffectFreeWhitelistStatus">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
+ <owner>shess@chromium.org</owner>
<summary>The instantiation status of the SideEffectFreeWhitelist.</summary>
</histogram>
@@ -25626,14 +25659,14 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</histogram>
<histogram name="SB2.SubPrefixes">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
+ <owner>shess@chromium.org</owner>
<summary>
The number of sub prefixes stored in the database after the last update.
</summary>
</histogram>
<histogram name="SB2.Update" units="milliseconds">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
+ <owner>shess@chromium.org</owner>
<summary>
The time from the receipt of the update request to the receipt of the final
update chunk.
@@ -25641,17 +25674,17 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</histogram>
<histogram name="SB2.UpdateRequestSize" units="bytes">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
+ <owner>shess@chromium.org</owner>
<summary>The payload size of update requests to the server.</summary>
</histogram>
<histogram name="SB2.UpdateResult" enum="SB2UpdateResult">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
+ <owner>shess@chromium.org</owner>
<summary>Result from trying to update the SafeBrowsing data.</summary>
</histogram>
<histogram name="SB2.UpdateSize" units="bytes">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
+ <owner>shess@chromium.org</owner>
<summary>The size of all the chunk URLs in an update response.</summary>
</histogram>
@@ -25672,7 +25705,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</histogram>
<histogram name="SB2.UpdateUrls">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
+ <owner>shess@chromium.org</owner>
<summary>The number of chunk URLs in an update response.</summary>
</histogram>
@@ -45226,6 +45259,9 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</enum>
<enum name="SB2BloomFailure" type="int">
+ <obsolete>
+ Bloom filter support deleted in October 2012.
+ </obsolete>
<int value="0" label="READ_OPEN"/>
<int value="1" label="READ_VERSION"/>
<int value="2" label="READ_NUM_KEYS"/>
@@ -45237,6 +45273,9 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</enum>
<enum name="SB2BloomFilterFalsePositives" type="int">
+ <obsolete>
+ Bloom filter support deleted in October 2012.
+ </obsolete>
<int value="0" label="ALL_MISSES"/>
<int value="1" label="FALSE_POSITIVE_MISSES"/>
</enum>
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698