Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 343273002: Revert r175934 "Accelerate small canvases if Ganesh is on." (Closed)

Created:
6 years, 6 months ago by jamesr
Modified:
6 years, 6 months ago
CC:
blink-reviews, jamesr, blink-reviews-html_chromium.org, abarth-chromium, dglazkov+blink, gavinp+loader_chromium.org, Nate Chapin
Project:
blink
Visibility:
Public.

Description

Revert r175934 "Accelerate small canvases if Ganesh is on." The problem with this patch is it is attempting to determine if we are gpu rasterized by querying the compositor but compositing state may not yet be initialized at the time the canvas is used, or may never be initialized in some cases. This is just conceptually broken and needs to be addressed with a different approach that doesn't query the compositor. TBR=abarth@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176654

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -19 lines) Patch
M Source/core/html/HTMLCanvasElement.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/core/loader/EmptyClients.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/page/ChromeClient.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/ChromeClientImpl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/ChromeClientImpl.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M public/platform/WebLayerTreeView.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jamesr
6 years, 6 months ago (2014-06-20 22:34:07 UTC) #1
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 6 months ago (2014-06-20 22:37:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/343273002/1
6 years, 6 months ago (2014-06-20 22:38:56 UTC) #3
jamesr
The CQ bit was unchecked by jamesr@chromium.org
6 years, 6 months ago (2014-06-20 22:41:00 UTC) #4
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 6 months ago (2014-06-20 22:41:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/343273002/1
6 years, 6 months ago (2014-06-20 22:41:08 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-20 22:42:05 UTC) #7
Message was sent while issue was closed.
Change committed as 176654

Powered by Google App Engine
This is Rietveld 408576698