Issue 343173003: ASSERTION FAILED: mainAxisExtent - mainAxisBorderAndPaddingExtentForChild(child) >= 0 in RenderFlex…

Issue 343173003: ASSERTION FAILED: mainAxisExtent - mainAxisBorderAndPaddingExtentForChild(child) >= 0 in RenderFlex… (Closed)

Created:
6 years, 6 months ago by harpreet.sk

Modified:
6 years, 5 months ago

Reviewers:
cbiesinger, leviw_travelin_and_unemployed, arpitabahuguna, tony

CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

ASSERTION FAILED: mainAxisExtent - mainAxisBorderAndPaddingExtentForChild(child) >= 0 in RenderFlexibleBox::preferredMainAxisContentExtentForChild The assertion mainAxisExtent - mainAxisBorderAndPaddingExtentForChild(child) >= 0 in RenderFlexibleBox::preferredMainAxisContentExtentForChild gets failed for the following case <html style="display: -webkit-inline-flex;"><frameset></frameset></html>. Actually this assertion is getting failed because when computing mainAxisExtent for the child (in our case frameset element) it calls the api maxPreferredLogicalWidth() in RenderBox. In this api it calls the api computePreferredLogicalWidths() of that child. Since child is a frameset element and there is no computePreferredLogicalWidths() defined in RenderFrameSet and since RenderFrameSet is a subclass of RenderBox so it calls the computePreferredLogicalWidths() of RenderBox. Since the computePreferredLogicalWidths() api of RenderBox does only clearPreferredLogicalWidthsDirty(); so the maxPreferredLogicalWidth return for frameset element is -1. This patch fixes this bug by implementing RenderFrameSet::computePreferredLogicalWidth. In this api we are simply initializing maxPreferredLogicalWidth and minPreferredLogicalWidth to 0. BUG=335121 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177459

Patch Set 1 #

Total comments: 2

Patch Set 2 : Implementing RenderFrameSet::computePreferredLogicalWidths. #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -1 line)			Patch
A	LayoutTests/css3/flexbox/mainAxisExtent-crash.html	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
A +	LayoutTests/css3/flexbox/mainAxisExtent-crash-expected.txt	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/RenderFrameSet.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/rendering/RenderFrameSet.cpp	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 17 (0 generated)

Expand Messages | Collapse Messages

tony

It seems to me that the bug is that {max,min}PreferredLogicalWidth aren't getting set. When do ...

6 years, 6 months ago (2014-06-23 17:29:06 UTC) #2

cbiesinger

On 2014/06/23 17:29:06, tony wrote: > It seems to me that the bug is that ...

6 years, 6 months ago (2014-06-24 00:28:06 UTC) #3

cbiesinger

https://codereview.chromium.org/343173003/diff/1/LayoutTests/css3/flexbox/mainAxisExtent-crash.html File LayoutTests/css3/flexbox/mainAxisExtent-crash.html (right): https://codereview.chromium.org/343173003/diff/1/LayoutTests/css3/flexbox/mainAxisExtent-crash.html#newcode2 LayoutTests/css3/flexbox/mainAxisExtent-crash.html:2: <html style="display: -webkit-inline-flex;"> By the way, FYI, new tests ...

6 years, 6 months ago (2014-06-24 00:31:26 UTC) #4

harpreet.sk

On 2014/06/24 00:28:06, cbiesinger wrote: > On 2014/06/23 17:29:06, tony wrote: > > It seems ...

6 years, 5 months ago (2014-06-27 09:42:55 UTC) #5

tony

I agree with cbiesinger: We should implement RenderFrameSet::computePreferredLogicalWidths.

6 years, 5 months ago (2014-06-27 16:37:13 UTC) #6

harpreet.sk

I have uploaded a new patch implementing RenderFrameSet::computePreferredLogicalWidth. Please have a look. https://codereview.chromium.org/343173003/diff/1/LayoutTests/css3/flexbox/mainAxisExtent-crash.html File LayoutTests/css3/flexbox/mainAxisExtent-crash.html ...

6 years, 5 months ago (2014-06-30 08:27:17 UTC) #7