Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: Source/core/rendering/RenderFrameSet.cpp

Issue 343173003: ASSERTION FAILED: mainAxisExtent - mainAxisBorderAndPaddingExtentForChild(child) >= 0 in RenderFlex… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Implementing RenderFrameSet::computePreferredLogicalWidths. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/rendering/RenderFrameSet.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /** 1 /**
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 2000 Simon Hausmann <hausmann@kde.org> 3 * (C) 2000 Simon Hausmann <hausmann@kde.org>
4 * (C) 2000 Stefan Schimanski (1Stein@gmx.de) 4 * (C) 2000 Stefan Schimanski (1Stein@gmx.de)
5 * Copyright (C) 2004, 2005, 2006 Apple Computer, Inc. 5 * Copyright (C) 2004, 2005, 2006 Apple Computer, Inc.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
146 return; 146 return;
147 } 147 }
148 yPos += m_rows.m_sizes[r]; 148 yPos += m_rows.m_sizes[r];
149 if (borderThickness && m_rows.m_allowBorder[r + 1]) { 149 if (borderThickness && m_rows.m_allowBorder[r + 1]) {
150 paintRowBorder(paintInfo, pixelSnappedIntRect(LayoutRect(adjustedPai ntOffset.x(), adjustedPaintOffset.y() + yPos, width(), borderThickness))); 150 paintRowBorder(paintInfo, pixelSnappedIntRect(LayoutRect(adjustedPai ntOffset.x(), adjustedPaintOffset.y() + yPos, width(), borderThickness)));
151 yPos += borderThickness; 151 yPos += borderThickness;
152 } 152 }
153 } 153 }
154 } 154 }
155 155
156 void RenderFrameSet::computePreferredLogicalWidths()
157 {
158 m_minPreferredLogicalWidth = 0;
159 m_maxPreferredLogicalWidth = 0;
160 clearPreferredLogicalWidthsDirty();
161 }
162
156 void RenderFrameSet::GridAxis::resize(int size) 163 void RenderFrameSet::GridAxis::resize(int size)
157 { 164 {
158 m_sizes.resize(size); 165 m_sizes.resize(size);
159 m_deltas.resize(size); 166 m_deltas.resize(size);
160 m_deltas.fill(0); 167 m_deltas.fill(0);
161 168
162 // To track edges for resizability and borders, we need to be (size + 1). Th is is because a parent frameset 169 // To track edges for resizability and borders, we need to be (size + 1). Th is is because a parent frameset
163 // may ask us for information about our left/top/right/bottom edges in order to make its own decisions about 170 // may ask us for information about our left/top/right/bottom edges in order to make its own decisions about
164 // what to do. We are capable of tainting that parent frameset's borders, so we have to cache this info. 171 // what to do. We are capable of tainting that parent frameset's borders, so we have to cache this info.
165 m_preventResize.resize(size + 1); 172 m_preventResize.resize(size + 1);
(...skipping 480 matching lines...) Expand 10 before | Expand all | Expand 10 after
646 return SetCursor; 653 return SetCursor;
647 } 654 }
648 if (canResizeColumn(roundedPoint)) { 655 if (canResizeColumn(roundedPoint)) {
649 cursor = columnResizeCursor(); 656 cursor = columnResizeCursor();
650 return SetCursor; 657 return SetCursor;
651 } 658 }
652 return RenderBox::getCursor(point, cursor); 659 return RenderBox::getCursor(point, cursor);
653 } 660 }
654 661
655 } // namespace WebCore 662 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderFrameSet.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698