Issue 34303002: chromeos: Wait for service to be available when getting system salt

Issue 34303002: chromeos: Wait for service to be available when getting system salt (Closed)

Created:
7 years, 2 months ago by hashimoto

Modified:
7 years, 2 months ago

Reviewers:
satorux1

CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

chromeos: Wait for service to be available when getting system salt Add CryptohomeClient::WaitForServiceToBeAvailable(). Use WaitForServiceToBeAvailable() from SystemSaltGetter. BUG=141009 R=satorux@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230067

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add test #

Total comments: 2

Patch Set 3 : Add comment #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+133 lines, -5 lines)			Patch
M	chromeos/chromeos.gyp	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chromeos/cryptohome/system_salt_getter.h	View		2 chunks	+7 lines, -0 lines	0 comments	Download
M	chromeos/cryptohome/system_salt_getter.cc	View		3 chunks	+13 lines, -4 lines	0 comments	Download
A	chromeos/cryptohome/system_salt_getter_unittest.cc	View	1	1 chunk	+65 lines, -0 lines	0 comments	Download
M	chromeos/dbus/cryptohome_client.h	View		2 chunks	+7 lines, -0 lines	0 comments	Download
M	chromeos/dbus/cryptohome_client.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	chromeos/dbus/fake_cryptohome_client.h	View	1 2	3 chunks	+10 lines, -0 lines	0 comments	Download
M	chromeos/dbus/fake_cryptohome_client.cc	View	1	3 chunks	+22 lines, -1 line	0 comments	Download
M	chromeos/dbus/mock_cryptohome_client.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

satorux1

would it be possible to write a unit test for SystemSaltGetter using FakeCryptohomeClient? https://codereview.chromium.org/34303002/diff/1/chromeos/cryptohome/system_salt_getter.cc File ...

7 years, 2 months ago (2013-10-22 03:54:51 UTC) #2

hashimoto

Added a test. PTAL https://codereview.chromium.org/34303002/diff/1/chromeos/cryptohome/system_salt_getter.cc File chromeos/cryptohome/system_salt_getter.cc (right): https://codereview.chromium.org/34303002/diff/1/chromeos/cryptohome/system_salt_getter.cc#newcode49 chromeos/cryptohome/system_salt_getter.cc:49: // TODO(hashimoto): Stop using GetSystemSaltSync(). ...

7 years, 2 months ago (2013-10-22 05:00:19 UTC) #3

satorux1

lgtm with a nit https://codereview.chromium.org/34303002/diff/60001/chromeos/dbus/fake_cryptohome_client.h File chromeos/dbus/fake_cryptohome_client.h (right): https://codereview.chromium.org/34303002/diff/60001/chromeos/dbus/fake_cryptohome_client.h#newcode156 chromeos/dbus/fake_cryptohome_client.h:156: // Changes the behavior of ...

7 years, 2 months ago (2013-10-22 05:08:09 UTC) #4

hashimoto

https://codereview.chromium.org/34303002/diff/60001/chromeos/dbus/fake_cryptohome_client.h File chromeos/dbus/fake_cryptohome_client.h (right): https://codereview.chromium.org/34303002/diff/60001/chromeos/dbus/fake_cryptohome_client.h#newcode156 chromeos/dbus/fake_cryptohome_client.h:156: // Changes the behavior of WaitForServiceToBeAvailable(). On 2013/10/22 05:08:10, ...

7 years, 2 months ago (2013-10-22 05:11:53 UTC) #5

hashimoto

7 years, 2 months ago (2013-10-22 07:38:31 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 manually as r230067 (presubmit successful).

Expand Messages | Collapse Messages