Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Unified Diff: pkg/yaml/lib/yaml.dart

Issue 342943006: Make YamlException inherit from SpanFormatException. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/yaml/lib/yaml.dart
diff --git a/pkg/yaml/lib/yaml.dart b/pkg/yaml/lib/yaml.dart
index f59719d638066f1a1fc3d93472f65bef81404095..80a63190c80416edd51125a8b9d7644b92b927bf 100644
--- a/pkg/yaml/lib/yaml.dart
+++ b/pkg/yaml/lib/yaml.dart
@@ -4,6 +4,8 @@
library yaml;
+import 'package:string_scanner/string_scanner.dart';
+
import 'src/composer.dart';
import 'src/constructor.dart';
import 'src/parser.dart';
@@ -40,7 +42,8 @@ loadYaml(String yaml, {String sourceName}) =>
YamlNode loadYamlNode(String yaml, {String sourceName}) {
var stream = loadYamlStream(yaml, sourceName: sourceName);
if (stream.length != 1) {
- throw new YamlException("Expected 1 document, were ${stream.length}.");
+ throw new YamlException("Expected 1 document, were ${stream.length}.",
+ stream.span);
}
return stream.nodes[0];
}
@@ -62,8 +65,8 @@ YamlList loadYamlStream(String yaml, {String sourceName}) {
var pair;
try {
pair = new Parser(yaml, sourceName).l_yamlStream();
- } on FormatException catch (error) {
- throw new YamlException(error.toString());
+ } on StringScannerException catch (error) {
+ throw new YamlException(error.message, error.span);
}
var nodes = pair.first

Powered by Google App Engine
This is Rietveld 408576698