Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1593)

Unified Diff: pkg/yaml/lib/src/yaml_exception.dart

Issue 342943006: Make YamlException inherit from SpanFormatException. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/yaml/lib/src/model.dart ('k') | pkg/yaml/lib/yaml.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/yaml/lib/src/yaml_exception.dart
diff --git a/pkg/yaml/lib/src/yaml_exception.dart b/pkg/yaml/lib/src/yaml_exception.dart
index a86327413d49fc9e05919881b5a1ac9d947266f5..9d437176834d42d4b54067e39f183f50cad7c44c 100644
--- a/pkg/yaml/lib/src/yaml_exception.dart
+++ b/pkg/yaml/lib/src/yaml_exception.dart
@@ -4,12 +4,11 @@
library yaml.exception;
-/// An error thrown by the YAML processor.
-class YamlException implements Exception {
- final String _msg;
-
- YamlException(this._msg);
+import 'package:source_maps/source_maps.dart';
- String toString() => _msg;
+/// An error thrown by the YAML processor.
+class YamlException extends SpanFormatException {
Bob Nystrom 2014/06/19 23:31:04 I'm generally hesitant to inherit across package b
nweiz 2014/06/19 23:47:52 The point of SpanException and SpanFormatException
+ YamlException(String message, Span span)
+ : super(message, span);
}
« no previous file with comments | « pkg/yaml/lib/src/model.dart ('k') | pkg/yaml/lib/yaml.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698