Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 342933003: Remove an unneccessary FIXME comment for HTMLToken (Closed)

Created:
6 years, 6 months ago by rtakacs
Modified:
6 years, 6 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, Inactive, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove an unneccessary FIXME comment for HTMLToken NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176648

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M Source/core/html/parser/HTMLToken.h View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
rtakacs
This is a patch for a FIXME: "This should use String instead of Vector<UChar>."
6 years, 6 months ago (2014-06-19 12:27:15 UTC) #1
abarth-chromium
https://codereview.chromium.org/342933003/diff/1/Source/core/html/parser/HTMLToken.h File Source/core/html/parser/HTMLToken.h (right): https://codereview.chromium.org/342933003/diff/1/Source/core/html/parser/HTMLToken.h#newcode455 Source/core/html/parser/HTMLToken.h:455: Vector<UChar> m_identifierBuffer; You haven't actually improved anything because you've ...
6 years, 6 months ago (2014-06-19 16:07:02 UTC) #2
eseidel
6 years, 6 months ago (2014-06-19 21:38:32 UTC) #3
abarth-chromium
LGTM
6 years, 6 months ago (2014-06-20 21:20:55 UTC) #4
rtakacs
The CQ bit was checked by rtakacs.u-szeged@partner.samsung.com
6 years, 6 months ago (2014-06-20 21:22:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtakacs.u-szeged@partner.samsung.com/342933003/20001
6 years, 6 months ago (2014-06-20 21:24:46 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-20 21:26:22 UTC) #7
Message was sent while issue was closed.
Change committed as 176648

Powered by Google App Engine
This is Rietveld 408576698