Remove an unneccessary FIXME comment for HTMLToken

Source/core/html/parser/HTMLToken.h

 /*
  * Copyright (C) 2013 Google, Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
  *    documentation and/or other materials provided with the distribution.
  *
  * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
  * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
  * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
  * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL APPLE INC. OR
  * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
  * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
  * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
  * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
  * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef HTMLToken_h
 #define HTMLToken_h
 
 #include "core/dom/Attribute.h"
+#include "core/html/parser/HTMLParserIdioms.h"
 #include "wtf/PassOwnPtr.h"
 #include "wtf/RefCounted.h"
 #include "wtf/RefPtr.h"
 
 namespace WebCore {
 
 class DoctypeData {
     WTF_MAKE_NONCOPYABLE(DoctypeData);
 public:
     DoctypeData()
         : m_hasPublicIdentifier(false)
         , m_hasSystemIdentifier(false)
         , m_forceQuirks(false)
     {
     }
 
-    // FIXME: This should use String instead of Vector<UChar>.
     bool m_hasPublicIdentifier;
     bool m_hasSystemIdentifier;
-    WTF::Vector<UChar> m_publicIdentifier;
-    WTF::Vector<UChar> m_systemIdentifier;
+    String m_publicIdentifier;
+    String m_systemIdentifier;
     bool m_forceQuirks;
 };
 
 static inline Attribute* findAttributeInVector(Vector<Attribute>& attributes, const QualifiedName& name)
 {
     for (unsigned i = 0; i < attributes.size(); ++i) {
         if (attributes.at(i).name().matches(name))
             return &attributes.at(i);
     }
     return 0;
@@ skipping 44 matching lines @@
         m_baseOffset = 0;
         // Don't call Vector::clear() as that would destroy the
         // alloced VectorBuffer. If the innerHTML'd content has
         // two 257 character text nodes in a row, we'll needlessly
         // thrash malloc. When we finally finish the parse the
         // HTMLToken will be destroyed and the VectorBuffer released.
         m_data.shrink(0);
         m_orAllData = 0;
     }
 
+    void finalizeDoctypePublicIdentifier()
+    {
+        m_doctypeData->m_publicIdentifier = attemptStaticStringCreation(m_identifierBuffer, Likely8Bit);
+        m_identifierBuffer.clear();
+    }
+
+    void finalizeDoctypeSystemIdentifier()
+    {
+        m_doctypeData->m_systemIdentifier = StringImpl::create8BitIfPossible(m_identifierBuffer);
+        m_identifierBuffer.clear();
+    }
+
     bool isUninitialized() { return m_type == Uninitialized; }
     Type type() const { return m_type; }
 
     void makeEndOfFile()
     {
         ASSERT(m_type == Uninitialized);
         m_type = EndOfFile;
     }
 
     /* Range and offset methods exposed for HTMLSourceTracker and HTMLViewSourceParser */
@@ skipping 58 matching lines @@
 
     void beginDOCTYPE(UChar character)
     {
         ASSERT(character);
         beginDOCTYPE();
         m_data.append(character);
         m_orAllData |= character;
     }
 
     // FIXME: Distinguish between a missing public identifer and an empty one.
-    const WTF::Vector<UChar>& publicIdentifier() const
+    const String& publicIdentifier() const
     {
         ASSERT(m_type == DOCTYPE);
         return m_doctypeData->m_publicIdentifier;
     }
 
     // FIXME: Distinguish between a missing system identifer and an empty one.
-    const WTF::Vector<UChar>& systemIdentifier() const
+    const String& systemIdentifier() const
     {
         ASSERT(m_type == DOCTYPE);
         return m_doctypeData->m_systemIdentifier;
     }
 
     void setPublicIdentifierToEmptyString()
     {
         ASSERT(m_type == DOCTYPE);
         m_doctypeData->m_hasPublicIdentifier = true;
-        m_doctypeData->m_publicIdentifier.clear();
     }
 
     void setSystemIdentifierToEmptyString()
     {
         ASSERT(m_type == DOCTYPE);
         m_doctypeData->m_hasSystemIdentifier = true;
-        m_doctypeData->m_systemIdentifier.clear();
     }
 
     void appendToPublicIdentifier(UChar character)
     {
         ASSERT(character);
         ASSERT(m_type == DOCTYPE);
         ASSERT(m_doctypeData->m_hasPublicIdentifier);
-        m_doctypeData->m_publicIdentifier.append(character);
+        m_identifierBuffer.append(character);
     }
 
     void appendToSystemIdentifier(UChar character)
     {
         ASSERT(character);
         ASSERT(m_type == DOCTYPE);
         ASSERT(m_doctypeData->m_hasSystemIdentifier);
-        m_doctypeData->m_systemIdentifier.append(character);
+        m_identifierBuffer.append(character);
     }
 
     PassOwnPtr<DoctypeData> releaseDoctypeData()
     {
         return m_doctypeData.release();
     }
 
     /* Start/End Tag Tokens */
 
     bool selfClosing() const
@@ skipping 191 matching lines @@
         m_data.clear();
         m_orAllData = 0;
     }
 
 private:
     Type m_type;
     Attribute::Range m_range; // Always starts at zero.
     int m_baseOffset;
     DataVector m_data;
     UChar m_orAllData;
+    Vector<UChar> m_identifierBuffer;

[abarth-chromium, 2014/06/19 16:07:02]

You haven't actually improved anything because you've just introduced this
buffer here.

not lgtm

 
     // For StartTag and EndTag
     bool m_selfClosing;
     AttributeList m_attributes;
 
     // A pointer into m_attributes used during lexing.
     Attribute* m_currentAttribute;
 
     // For DOCTYPE
     OwnPtr<DoctypeData> m_doctypeData;
 };
 
 }
 
 #endif