QUIC - Record reject reasons for CHLO message.

net/quic/crypto/quic_crypto_client_config.h

Index: net/quic/crypto/quic_crypto_client_config.h
diff --git a/net/quic/crypto/quic_crypto_client_config.h b/net/quic/crypto/quic_crypto_client_config.h
index 8aa4527bd735f9f5dc6e7383939677d5462a32cd..9e0c3b6cd79ba50d3f8133ef9cef1e52eac7ada5 100644
--- a/net/quic/crypto/quic_crypto_client_config.h
+++ b/net/quic/crypto/quic_crypto_client_config.h
@@ -13,6 +13,7 @@
 #include "base/strings/string_piece.h"
 #include "net/base/net_export.h"
 #include "net/quic/crypto/crypto_handshake.h"
+#include "net/quic/crypto/quic_crypto_server_config.h"

[wtc, 2014/06/24 21:02:16]

Nit: it seems strange for quic_crypto_client_config.h to include
quic_crypto_server_config.h. We should create a new header for the
HandshakeFailureReason type definition, or define HandshakeFailureReason in some
other header, such as crypto_protocol.h or crypto_handshake.h.

[ramant (doing other things), 2014/07/14 22:04:13]

Done.

 #include "net/quic/quic_protocol.h"
 #include "net/quic/quic_server_id.h"
 
@@ -208,6 +209,9 @@ class NET_EXPORT_PRIVATE QuicCryptoClientConfig : public QuicCryptoConfig {
                                    QuicCryptoNegotiatedParameters* out_params,
                                    std::string* error_details);
 
+  // Packs the |reason| into an uint32 value.

[wtc, 2014/06/24 21:02:16]

Nit: an => a

You may want to point out that only one bit is set in the output value, so the
output values can be XOR'ed together.

[ramant (doing other things), 2014/07/14 22:04:13]

Deleted this method.

+  uint32 RejectReasonToPackedError(HandshakeFailureReason reason);

[wtc, 2014/06/24 21:02:16]

I guess this method is public just to make it available to the unit tests?

[ramant (doing other things), 2014/07/14 22:04:13]

Deleted this method.

+
   ProofVerifier* proof_verifier() const;
 
   // SetProofVerifier takes ownership of a |ProofVerifier| that clients are