QUIC - Record reject reasons for CHLO message.

net/quic/crypto/quic_crypto_client_config.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_QUIC_CRYPTO_QUIC_CRYPTO_CLIENT_CONFIG_H_
 #define NET_QUIC_CRYPTO_QUIC_CRYPTO_CLIENT_CONFIG_H_
 
 #include <map>
 #include <string>
 #include <vector>
 
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/string_piece.h"
 #include "net/base/net_export.h"
 #include "net/quic/crypto/crypto_handshake.h"
+#include "net/quic/crypto/quic_crypto_server_config.h"

[wtc, 2014/06/24 21:02:16]

Nit: it seems strange for quic_crypto_client_config.h to include
quic_crypto_server_config.h. We should create a new header for the
HandshakeFailureReason type definition, or define HandshakeFailureReason in some
other header, such as crypto_protocol.h or crypto_handshake.h.

[ramant (doing other things), 2014/07/14 22:04:13]

Done.

 #include "net/quic/quic_protocol.h"
 #include "net/quic/quic_server_id.h"
 
 namespace net {
 
 class ChannelIDKey;
 class ChannelIDSource;
 class CryptoHandshakeMessage;
 class ProofVerifier;
 class ProofVerifyDetails;
@@ skipping 175 matching lines @@
   // present in a version negotiation packet previously recevied from the
   // server. The contents of this list will be compared against the list of
   // versions provided in the VER tag of the server hello.
   QuicErrorCode ProcessServerHello(const CryptoHandshakeMessage& server_hello,
                                    QuicConnectionId connection_id,
                                    const QuicVersionVector& negotiated_versions,
                                    CachedState* cached,
                                    QuicCryptoNegotiatedParameters* out_params,
                                    std::string* error_details);
 
+  // Packs the |reason| into an uint32 value.

[wtc, 2014/06/24 21:02:16]

Nit: an => a

You may want to point out that only one bit is set in the output value, so the
output values can be XOR'ed together.

[ramant (doing other things), 2014/07/14 22:04:13]

Deleted this method.

+  uint32 RejectReasonToPackedError(HandshakeFailureReason reason);

[wtc, 2014/06/24 21:02:16]

I guess this method is public just to make it available to the unit tests?

[ramant (doing other things), 2014/07/14 22:04:13]

Deleted this method.

+
   ProofVerifier* proof_verifier() const;
 
   // SetProofVerifier takes ownership of a |ProofVerifier| that clients are
   // free to use in order to verify certificate chains from servers. If a
   // ProofVerifier is set then the client will request a certificate chain from
   // the server.
   void SetProofVerifier(ProofVerifier* verifier);
 
   ChannelIDSource* channel_id_source() const;
 
@@ skipping 62 matching lines @@
 
   // The |user_agent_id_| passed in QUIC's CHLO message.
   std::string user_agent_id_;
 
   DISALLOW_COPY_AND_ASSIGN(QuicCryptoClientConfig);
 };
 
 }  // namespace net
 
 #endif  // NET_QUIC_CRYPTO_QUIC_CRYPTO_CLIENT_CONFIG_H_