Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 342773004: Use L###macro_arg instead of L#macro_arg to make a wide string literal (Closed)

Created:
6 years, 6 months ago by Reid Kleckner
Modified:
6 years, 6 months ago
Reviewers:
David Tseng
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Use L###macro_arg instead of L#macro_arg to make a wide string literal MSVC lexes L#macro_arg as a single wide string literal after pre-processing. Clang and other conforming C preprocessors lex this as a single 'L' token followed by a normal string literal. Using L###macro_arg works with all compilers. It should be parsed as 'L' '##' '#' 'macro_arg', where '#' stringizes the macro arg and '##' token pastes the two tokens together to form a single string literal. R=dtseng@chromium.org CC=thakis@chromium.org,hans@chromium.org BUG=82385 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278299

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M content/browser/accessibility/accessibility_tree_formatter_utils_win.cc View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Reid Kleckner
6 years, 6 months ago (2014-06-18 22:30:41 UTC) #1
David Tseng
lgtm Thanks for the fix; never built Chrome Windows with clang.
6 years, 6 months ago (2014-06-18 22:44:57 UTC) #2
Reid Kleckner
The CQ bit was checked by rnk@chromium.org
6 years, 6 months ago (2014-06-18 23:01:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rnk@chromium.org/342773004/1
6 years, 6 months ago (2014-06-18 23:03:18 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 07:45:08 UTC) #5
Message was sent while issue was closed.
Change committed as 278299

Powered by Google App Engine
This is Rietveld 408576698