DevTools: Debugger StepInto/Out/Over initiated from a framework should not black-box it.

DevTools: Debugger StepInto/Out/Over initiated from a framework should not black-box it.

BUG=267592
R=yurys, pfeldman@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177170

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177228

[aandrey, 2014-06-18 16:07:07]

PTAL

[pfeldman, 2014-06-18 18:25:24]

But this means that if you accidentally end up in a framework, you won't be able
to quickly escape from it?

[aandrey, 2014-06-20 10:06:27]

On 2014/06/18 18:25:24, pfeldman wrote:
> But this means that if you accidentally end up in a framework, you won't be
able
> to quickly escape from it?

The whole idea of framework blackboxing is to avoid ending up *accidentally* in
a framework, isn't it?
Nevertheless, addressing your concern, the quick way to escape it is just to
press "resume" button.

This patch is about *intentional* pausing in a framework (e.g. via a
breakpoint).
W/o this patch, if you press a StepInto from that position, you may end up
virtually anywhere, and the experience gets really confusing.

[aandrey, 2014-06-20 11:53:08]

Added more tests. PTAL.

[pfeldman, 2014-06-27 13:26:41]

ok, lgtm

[aandrey, 2014-06-29 00:19:31]

The CQ bit was checked by aandrey@chromium.org

[commit-bot: I haz the power, 2014-06-29 00:19:58]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/aandrey@chromium.org/342713002/20001

[commit-bot: I haz the power, 2014-06-29 01:24:48]

Change committed as 177170

[loislo, 2014-06-30 16:14:08]

A revert of this CL has been created in
https://codereview.chromium.org/360053002/ by loislo@chromium.org.

The reason for reverting is: live-edit.html is failing in a batch of tests.

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40....

[aandrey, 2014-06-30 16:28:17]

The CQ bit was checked by aandrey@chromium.org

[commit-bot: I haz the power, 2014-06-30 16:29:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/aandrey@chromium.org/342713002/60001

[commit-bot: I haz the power, 2014-06-30 17:31:28]

Change committed as 177228