Source/core/inspector/InspectorDebuggerAgent.h - Issue 342713002: DevTools: Debugger StepInto/Out/Over initiated from a framework should not black-box it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InspectorDebuggerAgent.h

Issue 342713002: DevTools: Debugger StepInto/Out/Over initiated from a framework should not black-box it. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: added missing null check Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/inspector/sources/debugger/resources/framework.js ('k') | Source/core/inspector/InspectorDebuggerAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/inspector/InspectorDebuggerAgent.h

diff --git a/Source/core/inspector/InspectorDebuggerAgent.h b/Source/core/inspector/InspectorDebuggerAgent.h

index ea959df9cf824d5a239cf2f0258c9c8353397f7f..15a905b9da42c0eb98f9332431858e889aa0dd2a 100644

--- a/Source/core/inspector/InspectorDebuggerAgent.h

+++ b/Source/core/inspector/InspectorDebuggerAgent.h

@@ -199,6 +199,7 @@ protected:

private:

SkipPauseRequest shouldSkipExceptionPause();

SkipPauseRequest shouldSkipStepPause();

+ bool isTopCallFrameInFramework();

void cancelPauseOnNextStatement();

void addMessageToConsole(MessageSource, MessageType);

@@ -237,6 +238,7 @@ private:

RefPtr<JSONObject> m_breakAuxData;

bool m_javaScriptPauseScheduled;

bool m_debuggerStepScheduled;

+ bool m_steppingFromFramework;

bool m_pausingOnNativeEvent;

Listener* m_listener;

« no previous file with comments | « LayoutTests/inspector/sources/debugger/resources/framework.js ('k') | Source/core/inspector/InspectorDebuggerAgent.cpp » ('j') | no next file with comments »