Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 342653004: Mojo: Add logging macros (and supporting code) for use in mojo/public/cpp. (Closed)

Created:
6 years, 6 months ago by viettrungluu
Modified:
6 years, 6 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Mojo: Add logging macros (and supporting code) for use in mojo/public/cpp. The logging macros should be usable by anything that depends on mojo/public/cpp/environment (i.e., everything except mojo/public/cpp/{system,utility}). The macros are a simplified version of the usual ones in base/logging.h, omitting (D)CHECK_{EQ,NE,GT,...}. Also currently not present are (D)VLOG, etc. I'm considering also adding MOJO_(D)CHECK_OK(mojo_result) and MOJO_(D)LOG_IF_NOT_OK(level, mojo_result), which might be used similarly to (D)PCHECK and (D)PLOG (for errno/GetLastError()). But I'd do that separately. R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278504

Patch Set 1 #

Total comments: 1

Patch Set 2 : abort #

Patch Set 3 : rebased #

Patch Set 4 : split lines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+597 lines, -4 lines) Patch
M mojo/environment/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/mojo.gyp View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/mojo_public.gypi View 2 chunks +3 lines, -0 lines 0 comments Download
M mojo/public/cpp/environment/lib/default_logger.cc View 2 chunks +8 lines, -4 lines 0 comments Download
A mojo/public/cpp/environment/lib/logging.cc View 1 chunk +45 lines, -0 lines 0 comments Download
A mojo/public/cpp/environment/logging.h View 1 chunk +87 lines, -0 lines 0 comments Download
A mojo/public/cpp/environment/tests/logging_unittest.cc View 1 2 3 1 chunk +448 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
viettrungluu
(Dependent on https://codereview.chromium.org/339403003/.)
6 years, 6 months ago (2014-06-19 04:10:57 UTC) #1
darin (slow to review)
LGTM https://codereview.chromium.org/342653004/diff/1/mojo/public/cpp/environment/logging.h File mojo/public/cpp/environment/logging.h (right): https://codereview.chromium.org/342653004/diff/1/mojo/public/cpp/environment/logging.h#newcode8 mojo/public/cpp/environment/logging.h:8: // TODO(vtl): It's weird that this is in ...
6 years, 6 months ago (2014-06-19 05:15:06 UTC) #2
viettrungluu
On 2014/06/19 05:15:06, darin wrote: > LGTM > > https://codereview.chromium.org/342653004/diff/1/mojo/public/cpp/environment/logging.h > File mojo/public/cpp/environment/logging.h (right): > ...
6 years, 6 months ago (2014-06-19 06:48:02 UTC) #3
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 6 months ago (2014-06-19 18:00:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/342653004/60001
6 years, 6 months ago (2014-06-19 18:02:43 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-19 21:42:56 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/74936)
6 years, 6 months ago (2014-06-19 21:42:56 UTC) #7
viettrungluu
6 years, 6 months ago (2014-06-19 22:11:38 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 manually as r278504.

Powered by Google App Engine
This is Rietveld 408576698