Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 339403003: Mojo: Make GetDefault{AsyncWaiter,Logger} static methods of Environment. (Closed)

Created:
6 years, 6 months ago by viettrungluu
Modified:
6 years, 6 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Mojo: Make GetDefault{AsyncWaiter,Logger} static methods of Environment. Also: * Move SetMinimumLogLevel() into MojoLogger itself. (This is somewhat unfortunate, since may not be thread-safe -- in particular, when sharing a copy of base's logging as in a component=shared_library build, it becomes blatantly unsafe. Thus it's of slightly dubious value. But it's where it belongs logically. Of course, sharing a log level across applications that are cohabiting a process is dubious. Avoiding this would mean at least layering a log level on top of Chromium's.) * Allow the (standalone) Environment's choices for default AsyncWaiter and/or Logger to be overridden. R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278401

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -171 lines) Patch
M mojo/android/system/core_impl.cc View 3 chunks +4 lines, -7 lines 0 comments Download
M mojo/bindings/js/support.cc View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/bindings/js/waiting_callback.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/environment/BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download
D mojo/environment/default_async_waiter.cc View 1 chunk +0 lines, -15 lines 0 comments Download
D mojo/environment/default_logger.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M mojo/environment/default_logger_impl.cc View 1 chunk +6 lines, -1 line 0 comments Download
M mojo/environment/environment.cc View 2 chunks +17 lines, -0 lines 0 comments Download
M mojo/mojo.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M mojo/mojo_public.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/c/environment/logger.h View 2 chunks +11 lines, -1 line 0 comments Download
M mojo/public/cpp/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
A + mojo/public/cpp/bindings/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/cpp/bindings/interface_impl.h View 4 chunks +13 lines, -9 lines 0 comments Download
M mojo/public/cpp/bindings/interface_ptr.h View 3 chunks +5 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/lib/connector.h View 2 chunks +5 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/lib/interface_impl_internal.h View 2 chunks +2 lines, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/interface_ptr_internal.h View 2 chunks +4 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/lib/router.h View 2 chunks +2 lines, -1 line 0 comments Download
D mojo/public/cpp/environment/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D mojo/public/cpp/environment/default_async_waiter.h View 1 chunk +0 lines, -17 lines 0 comments Download
D mojo/public/cpp/environment/default_logger.h View 1 chunk +0 lines, -17 lines 0 comments Download
M mojo/public/cpp/environment/environment.h View 1 chunk +17 lines, -4 lines 0 comments Download
A mojo/public/cpp/environment/lib/default_async_waiter.h View 1 chunk +18 lines, -0 lines 0 comments Download
M mojo/public/cpp/environment/lib/default_async_waiter.cc View 2 chunks +8 lines, -6 lines 0 comments Download
A + mojo/public/cpp/environment/lib/default_logger.h View 1 chunk +7 lines, -7 lines 0 comments Download
M mojo/public/cpp/environment/lib/default_logger.cc View 2 chunks +12 lines, -14 lines 0 comments Download
D mojo/public/cpp/environment/lib/default_logger_internal.h View 1 chunk +0 lines, -20 lines 0 comments Download
M mojo/public/cpp/environment/lib/environment.cc View 1 chunk +39 lines, -5 lines 0 comments Download
M mojo/public/cpp/environment/tests/async_waiter_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/public/cpp/environment/tests/logger_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M mojo/public/cpp/gles2/gles2.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
viettrungluu
6 years, 6 months ago (2014-06-18 20:28:26 UTC) #1
viettrungluu
Friendly ping.
6 years, 6 months ago (2014-06-19 06:48:27 UTC) #2
darin (slow to review)
LGTM
6 years, 6 months ago (2014-06-19 06:59:31 UTC) #3
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 6 months ago (2014-06-19 07:09:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/339403003/1
6 years, 6 months ago (2014-06-19 07:11:05 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-19 11:39:16 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/74774)
6 years, 6 months ago (2014-06-19 11:39:18 UTC) #7
viettrungluu
6 years, 6 months ago (2014-06-19 16:29:35 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as r278401.

Powered by Google App Engine
This is Rietveld 408576698