Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 342553008: Avoid to use abbreviated names in {first,last}EditableVisiblePosition{After,Before}PositionInRoot (Closed)

Created:
6 years, 6 months ago by yosin_UTC9
Modified:
6 years, 6 months ago
Reviewers:
yoichio, Yuta Kitamura
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Avoid to use abbreviated names in {first,last}EditableVisiblePosition{After,Before}PositionInRoot This patch renames abbreviated name "p" to "editablePosition" in {first,last}EditableVisiblePosition{After,Before}PositionInRoot for improving readability and ease of maintenance. This patch is a preparation of introducing |lastEditablePositionBeforePositionInRoot. BUG=n/a TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176491

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M Source/core/editing/htmlediting.cpp View 2 chunks +14 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
yosin_UTC9
Could you review this patch? Thanks in advance. I tried to replace all abbreviated names ...
6 years, 6 months ago (2014-06-19 04:43:05 UTC) #1
Yuta Kitamura
rslgtm
6 years, 6 months ago (2014-06-19 05:27:14 UTC) #2
yosin_UTC9
The CQ bit was checked by yosin@chromium.org
6 years, 6 months ago (2014-06-19 05:51:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yosin@chromium.org/342553008/1
6 years, 6 months ago (2014-06-19 05:52:36 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 05:56:50 UTC) #5
Message was sent while issue was closed.
Change committed as 176491

Powered by Google App Engine
This is Rietveld 408576698