Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Unified Diff: sdk/lib/_internal/pub/test/validator/compiled_dartdoc_test.dart

Issue 342553002: Respect git's ignore rules pervasively in pub. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: code review, performance improvements Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/pub/test/serve/serves_hidden_assets_that_arent_gitignored_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/pub/test/validator/compiled_dartdoc_test.dart
diff --git a/sdk/lib/_internal/pub/test/validator/compiled_dartdoc_test.dart b/sdk/lib/_internal/pub/test/validator/compiled_dartdoc_test.dart
index 425ad83ae6bf5af62e28b1df1a694ef2647a21a0..38ee28499a4971794183290c79b30f6eda9ca1c0 100644
--- a/sdk/lib/_internal/pub/test/validator/compiled_dartdoc_test.dart
+++ b/sdk/lib/_internal/pub/test/validator/compiled_dartdoc_test.dart
@@ -33,22 +33,73 @@ main() {
]).create();
expectNoValidationError(compiledDartdoc);
});
+
+ integration('contains compiled dartdoc in a hidden directory', () {
+ ensureGit();
+
+ d.dir(appPath, [
+ d.dir(".doc-out", [
+ d.file('nav.json', ''),
+ d.file('index.html', ''),
+ d.file('styles.css', ''),
+ d.file('dart-logo-small.png', ''),
+ d.file('client-live-nav.js', '')
+ ])
+ ]).create();
+ expectNoValidationError(compiledDartdoc);
+ });
+
+ integration('contains compiled dartdoc in a gitignored directory', () {
+ ensureGit();
+
+ d.git(appPath, [
+ d.dir("doc-out", [
+ d.file('nav.json', ''),
+ d.file('index.html', ''),
+ d.file('styles.css', ''),
+ d.file('dart-logo-small.png', ''),
+ d.file('client-live-nav.js', '')
+ ]),
+ d.file(".gitignore", "/doc-out")
+ ]).create();
+ expectNoValidationError(compiledDartdoc);
+ });
});
- integration('should consider a package invalid if it contains compiled '
- 'dartdoc', () {
- d.validPackage.create();
-
- d.dir(appPath, [
- d.dir('doc-out', [
- d.file('nav.json', ''),
- d.file('index.html', ''),
- d.file('styles.css', ''),
- d.file('dart-logo-small.png', ''),
- d.file('client-live-nav.js', '')
- ])
- ]).create();
-
- expectValidationWarning(compiledDartdoc);
+ group("should consider a package invalid if it", () {
+ integration('contains compiled dartdoc', () {
+ d.validPackage.create();
+
+ d.dir(appPath, [
+ d.dir('doc-out', [
+ d.file('nav.json', ''),
+ d.file('index.html', ''),
+ d.file('styles.css', ''),
+ d.file('dart-logo-small.png', ''),
+ d.file('client-live-nav.js', '')
+ ])
+ ]).create();
+
+ expectValidationWarning(compiledDartdoc);
+ });
+
+ integration('contains compiled dartdoc in a non-gitignored hidden '
+ 'directory', () {
+ ensureGit();
+
+ d.validPackage.create();
+
+ d.git(appPath, [
+ d.dir('.doc-out', [
+ d.file('nav.json', ''),
+ d.file('index.html', ''),
+ d.file('styles.css', ''),
+ d.file('dart-logo-small.png', ''),
+ d.file('client-live-nav.js', '')
+ ])
+ ]).create();
+
+ expectValidationWarning(compiledDartdoc);
+ });
});
}
« no previous file with comments | « sdk/lib/_internal/pub/test/serve/serves_hidden_assets_that_arent_gitignored_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698