Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Side by Side Diff: sdk/lib/_internal/pub/test/validator/compiled_dartdoc_test.dart

Issue 342553002: Respect git's ignore rules pervasively in pub. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: code review, performance improvements Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « sdk/lib/_internal/pub/test/serve/serves_hidden_assets_that_arent_gitignored_test.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import 'package:scheduled_test/scheduled_test.dart'; 5 import 'package:scheduled_test/scheduled_test.dart';
6 6
7 import '../../lib/src/entrypoint.dart'; 7 import '../../lib/src/entrypoint.dart';
8 import '../../lib/src/validator.dart'; 8 import '../../lib/src/validator.dart';
9 import '../../lib/src/validator/compiled_dartdoc.dart'; 9 import '../../lib/src/validator/compiled_dartdoc.dart';
10 import '../descriptor.dart' as d; 10 import '../descriptor.dart' as d;
(...skipping 15 matching lines...) Expand all
26 d.dir(appPath, [ 26 d.dir(appPath, [
27 d.dir("doc-out", [ 27 d.dir("doc-out", [
28 d.file("nav.json", ""), 28 d.file("nav.json", ""),
29 d.file("index.html", ""), 29 d.file("index.html", ""),
30 d.file("styles.css", ""), 30 d.file("styles.css", ""),
31 d.file("dart-logo-small.png", "") 31 d.file("dart-logo-small.png", "")
32 ]) 32 ])
33 ]).create(); 33 ]).create();
34 expectNoValidationError(compiledDartdoc); 34 expectNoValidationError(compiledDartdoc);
35 }); 35 });
36
37 integration('contains compiled dartdoc in a hidden directory', () {
38 ensureGit();
39
40 d.dir(appPath, [
41 d.dir(".doc-out", [
42 d.file('nav.json', ''),
43 d.file('index.html', ''),
44 d.file('styles.css', ''),
45 d.file('dart-logo-small.png', ''),
46 d.file('client-live-nav.js', '')
47 ])
48 ]).create();
49 expectNoValidationError(compiledDartdoc);
50 });
51
52 integration('contains compiled dartdoc in a gitignored directory', () {
53 ensureGit();
54
55 d.git(appPath, [
56 d.dir("doc-out", [
57 d.file('nav.json', ''),
58 d.file('index.html', ''),
59 d.file('styles.css', ''),
60 d.file('dart-logo-small.png', ''),
61 d.file('client-live-nav.js', '')
62 ]),
63 d.file(".gitignore", "/doc-out")
64 ]).create();
65 expectNoValidationError(compiledDartdoc);
66 });
36 }); 67 });
37 68
38 integration('should consider a package invalid if it contains compiled ' 69 group("should consider a package invalid if it", () {
39 'dartdoc', () { 70 integration('contains compiled dartdoc', () {
40 d.validPackage.create(); 71 d.validPackage.create();
41 72
42 d.dir(appPath, [ 73 d.dir(appPath, [
43 d.dir('doc-out', [ 74 d.dir('doc-out', [
44 d.file('nav.json', ''), 75 d.file('nav.json', ''),
45 d.file('index.html', ''), 76 d.file('index.html', ''),
46 d.file('styles.css', ''), 77 d.file('styles.css', ''),
47 d.file('dart-logo-small.png', ''), 78 d.file('dart-logo-small.png', ''),
48 d.file('client-live-nav.js', '') 79 d.file('client-live-nav.js', '')
49 ]) 80 ])
50 ]).create(); 81 ]).create();
51 82
52 expectValidationWarning(compiledDartdoc); 83 expectValidationWarning(compiledDartdoc);
84 });
85
86 integration('contains compiled dartdoc in a non-gitignored hidden '
87 'directory', () {
88 ensureGit();
89
90 d.validPackage.create();
91
92 d.git(appPath, [
93 d.dir('.doc-out', [
94 d.file('nav.json', ''),
95 d.file('index.html', ''),
96 d.file('styles.css', ''),
97 d.file('dart-logo-small.png', ''),
98 d.file('client-live-nav.js', '')
99 ])
100 ]).create();
101
102 expectValidationWarning(compiledDartdoc);
103 });
53 }); 104 });
54 } 105 }
OLDNEW
« no previous file with comments | « sdk/lib/_internal/pub/test/serve/serves_hidden_assets_that_arent_gitignored_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698