sdk/lib/_internal/pub/lib/src/validator/name.dart - Issue 342553002: Respect git's ignore rules pervasively in pub.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/pub/lib/src/validator/name.dart

Issue 342553002: Respect git's ignore rules pervasively in pub. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: code review, performance improvements Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/_internal/pub/lib/src/validator/name.dart

diff --git a/sdk/lib/_internal/pub/lib/src/validator/name.dart b/sdk/lib/_internal/pub/lib/src/validator/name.dart

index 1b77ead1bee1f786eb88a31d165deef021d8c524..b939ac81fcf042ac4b502ed259bfc9dfcbc5b7f9 100644

--- a/sdk/lib/_internal/pub/lib/src/validator/name.dart

+++ b/sdk/lib/_internal/pub/lib/src/validator/name.dart

@@ -53,7 +53,7 @@ class NameValidator extends Validator {

List<String> get _libraries {

var libDir = path.join(entrypoint.root.dir, "lib");

if (!dirExists(libDir)) return [];

- return listDir(libDir, recursive: true)

+ return entrypoint.root.listFiles(beneath: libDir)

.map((file) => path.relative(file, from: path.dirname(libDir)))

.where((file) => !path.split(file).contains("src") &&

path.extension(file) == '.dart')