sdk/lib/_internal/pub/lib/src/validator/compiled_dartdoc.dart - Issue 342553002: Respect git's ignore rules pervasively in pub.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/pub/lib/src/validator/compiled_dartdoc.dart

Issue 342553002: Respect git's ignore rules pervasively in pub. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: code review, performance improvements Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/_internal/pub/lib/src/validator/compiled_dartdoc.dart

diff --git a/sdk/lib/_internal/pub/lib/src/validator/compiled_dartdoc.dart b/sdk/lib/_internal/pub/lib/src/validator/compiled_dartdoc.dart

index 400e6b2271b402c3c6b8bc02a4cb0f3efd402ed9..6ad79ce6b535939e08cf7e1462b9a2a9ddde4dfc 100644

--- a/sdk/lib/_internal/pub/lib/src/validator/compiled_dartdoc.dart

+++ b/sdk/lib/_internal/pub/lib/src/validator/compiled_dartdoc.dart

@@ -21,7 +21,7 @@ class CompiledDartdocValidator extends Validator {

Future validate() {

return syncFuture(() {

- for (var entry in listDir(entrypoint.root.dir, recursive: true)) {

+ for (var entry in entrypoint.root.listFiles()) {

if (path.basename(entry) != "nav.json") continue;

var dir = path.dirname(entry);