First pass at mobile (and other) SDCH limit revisions.

Do a quick tweak downwards to SDCH memory limits (esp for mobile).

This will allow experimentation to occur in M37 without concern about
blowing out memory.  A more thorough memory limit re-evaluation
is expected in M38.

BUG=374917
R=cbentzel@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278590

[Randy Smith (Not in Mondays), 2014-06-17 19:05:25]

Chris: I actually think you're the best person to consult with about (and hence
review) this change.  PTAL?

[cbentzel, 2014-06-18 20:47:43]

https://codereview.chromium.org/342523002/diff/1/net/base/sdch_manager.cc
File net/base/sdch_manager.cc (right):

https://codereview.chromium.org/342523002/diff/1/net/base/sdch_manager.cc#new...
net/base/sdch_manager.cc:24: const size_t SdchManager::kMaxDictionaryCount = 2;
Limit we agreed on was 150KB max for Android - this looks like 600KB.

https://codereview.chromium.org/342523002/diff/1/net/base/sdch_manager.cc#new...
net/base/sdch_manager.cc:28: const size_t SdchManager::kMaxDictionaryCount = 5;
Why did these change?

[Randy Smith (Not in Mondays), 2014-06-18 21:16:40]

PTAL?

https://codereview.chromium.org/342523002/diff/1/net/base/sdch_manager.cc
File net/base/sdch_manager.cc (right):

https://codereview.chromium.org/342523002/diff/1/net/base/sdch_manager.cc#new...
net/base/sdch_manager.cc:24: const size_t SdchManager::kMaxDictionaryCount = 2;
On 2014/06/18 20:47:43, cbentzel wrote:
> Limit we agreed on was 150KB max for Android - this looks like 600KB. 

Fixed.

https://codereview.chromium.org/342523002/diff/1/net/base/sdch_manager.cc#new...
net/base/sdch_manager.cc:28: const size_t SdchManager::kMaxDictionaryCount = 5;
On 2014/06/18 20:47:43, cbentzel wrote:
> Why did these change?

Because I think desktop chrome is a bit of a pig around SDCH at the moment.  But
I probably shouldn't change things unless I have some data to drive that with;
reverted.

[cbentzel, 2014-06-19 09:04:24]

On 2014/06/18 21:16:40, rdsmith wrote:
> PTAL?
> 
> https://codereview.chromium.org/342523002/diff/1/net/base/sdch_manager.cc
> File net/base/sdch_manager.cc (right):
> 
>
https://codereview.chromium.org/342523002/diff/1/net/base/sdch_manager.cc#new...
> net/base/sdch_manager.cc:24: const size_t SdchManager::kMaxDictionaryCount =
2;
> On 2014/06/18 20:47:43, cbentzel wrote:
> > Limit we agreed on was 150KB max for Android - this looks like 600KB. 
> 
> Fixed.
> 
>
https://codereview.chromium.org/342523002/diff/1/net/base/sdch_manager.cc#new...
> net/base/sdch_manager.cc:28: const size_t SdchManager::kMaxDictionaryCount =
5;
> On 2014/06/18 20:47:43, cbentzel wrote:
> > Why did these change?
> 
> Because I think desktop chrome is a bit of a pig around SDCH at the moment. 
But
> I probably shouldn't change things unless I have some data to drive that with;
> reverted.

LGTM

[Randy Smith (Not in Mondays), 2014-06-19 15:10:35]

The CQ bit was checked by rdsmith@chromium.org

[commit-bot: I haz the power, 2014-06-19 15:13:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rdsmith@chromium.org/342523002/20001

[commit-bot: I haz the power, 2014-06-19 19:14:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-19 19:14:59]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)

[Randy Smith (Not in Mondays), 2014-06-19 20:28:35]

Chris: Re-review new test changes?

[cbentzel, 2014-06-19 20:42:44]

On 2014/06/19 20:28:35, rdsmith wrote:
> Chris: Re-review new test changes?

LGTM

[Randy Smith (Not in Mondays), 2014-06-19 22:09:06]

The CQ bit was checked by rdsmith@chromium.org

[commit-bot: I haz the power, 2014-06-19 22:10:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rdsmith@chromium.org/342523002/60001

[commit-bot: I haz the power, 2014-06-20 04:30:10]

Change committed as 278590