First pass at mobile (and other) SDCH limit revisions.

net/base/sdch_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/base/sdch_manager.h"
 
 #include "base/base64.h"
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "crypto/sha2.h"
 #include "net/base/registry_controlled_domains/registry_controlled_domain.h"
 #include "net/url_request/url_request_http_job.h"
 
 namespace net {
 
 //------------------------------------------------------------------------------
 // static
-const size_t SdchManager::kMaxDictionarySize = 1000000;
 
+// Adjust SDCH limits downwards for mobile.
+#if defined(OS_ANDROID) || defined(OS_IOS)
 // static
-const size_t SdchManager::kMaxDictionaryCount = 20;
+const size_t SdchManager::kMaxDictionaryCount = 2;

[cbentzel, 2014/06/18 20:47:43]

Limit we agreed on was 150KB max for Android - this looks like 600KB. 

[Randy Smith (Not in Mondays), 2014/06/18 21:16:40]

Fixed.

+const size_t SdchManager::kMaxDictionarySize = 300 * 1000;
+#else
+// static
+const size_t SdchManager::kMaxDictionaryCount = 5;

[cbentzel, 2014/06/18 20:47:43]

Why did these change?

[Randy Smith (Not in Mondays), 2014/06/18 21:16:40]

Because I think desktop chrome is a bit of a pig around SDCH at the moment.  But
I probably shouldn't change things unless I have some data to drive that with;
reverted.

+const size_t SdchManager::kMaxDictionarySize = 500 * 1000;
+#endif
 
 // static
 bool SdchManager::g_sdch_enabled_ = true;
 
 // static
 bool SdchManager::g_secure_scheme_supported_ = false;
 
 //------------------------------------------------------------------------------
 SdchManager::Dictionary::Dictionary(const std::string& dictionary_text,
                                     size_t offset,
@@ skipping 516 matching lines @@
       case '/':
         (*output)[i] = '_';
         continue;
       default:
         continue;
     }
   }
 }
 
 }  // namespace net