Visual refresh of allocation profile page

runtime/vm/isolate.h

Index: runtime/vm/isolate.h
diff --git a/runtime/vm/isolate.h b/runtime/vm/isolate.h
index 95a7954411ff42e30bee597512105a0988d1f3c8..0bda380800426c91e9ab598371b8ea7ed34d3798 100644
--- a/runtime/vm/isolate.h
+++ b/runtime/vm/isolate.h
@@ -461,6 +461,23 @@ class Isolate : public BaseIsolate {
     deopt_context_ = value;
   }
 
+  void timestampLastAllocationProfileAccumulatorReset() {

[koda, 2014/06/17 21:04:07]

Naming convention: start with uppercase.

Also, please add a prefix like "Update" or "Set" to the mutators, to distinguish
them more from the accessors.

[Cutch, 2014/06/18 14:35:04]

Done.

+    timestamp_last_allocationprofile_accumulator_reset_ =
+        OS::GetCurrentTimeMillis();
+  }
+
+  int64_t timestamp_last_allocationprofile_accumulator_reset() const {
+    return timestamp_last_allocationprofile_accumulator_reset_;
+  }
+
+  void timestampLastAllocationProfileGC() {

[koda, 2014/06/17 21:04:07]

Ditto.

[Cutch, 2014/06/18 14:35:04]

Done.

+    timestamp_last_allocationprofile_gc_ = OS::GetCurrentTimeMillis();
+  }
+
+  int64_t timestamp_last_allocationprofile_gc() const {
+    return timestamp_last_allocationprofile_gc_;
+  }
+
   intptr_t BlockClassFinalization() {
     ASSERT(defer_finalization_count_ >= 0);
     return defer_finalization_count_++;
@@ -603,6 +620,10 @@ class Isolate : public BaseIsolate {
   char* stacktrace_;
   intptr_t stack_frame_index_;
 
+  // Timestamps of last operation via service.

[koda, 2014/06/17 21:04:07]

Longer-term, I wish we had a different way of associating auxiliary info with an
isolate, rather than adding more fields.

[Cutch, 2014/06/18 14:35:04]

I had the same thought. Agreed.

+  int64_t timestamp_last_allocationprofile_accumulator_reset_;
+  int64_t timestamp_last_allocationprofile_gc_;
+
   bool cha_used_;
 
   // Ring buffer of objects assigned an id.