Visual refresh of allocation profile page

runtime/vm/isolate.h

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_ISOLATE_H_
 #define VM_ISOLATE_H_
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "platform/thread.h"
@@ skipping 443 matching lines @@
   TraceBuffer* trace_buffer() {
     return trace_buffer_;
   }
 
   DeoptContext* deopt_context() const { return deopt_context_; }
   void set_deopt_context(DeoptContext* value) {
     ASSERT(value == NULL || deopt_context_ == NULL);
     deopt_context_ = value;
   }
 
+  void timestampLastAllocationProfileAccumulatorReset() {

[koda, 2014/06/17 21:04:07]

Naming convention: start with uppercase.

Also, please add a prefix like "Update" or "Set" to the mutators, to distinguish
them more from the accessors.

[Cutch, 2014/06/18 14:35:04]

Done.

+    timestamp_last_allocationprofile_accumulator_reset_ =
+        OS::GetCurrentTimeMillis();
+  }
+
+  int64_t timestamp_last_allocationprofile_accumulator_reset() const {
+    return timestamp_last_allocationprofile_accumulator_reset_;
+  }
+
+  void timestampLastAllocationProfileGC() {

[koda, 2014/06/17 21:04:07]

Ditto.

[Cutch, 2014/06/18 14:35:04]

Done.

+    timestamp_last_allocationprofile_gc_ = OS::GetCurrentTimeMillis();
+  }
+
+  int64_t timestamp_last_allocationprofile_gc() const {
+    return timestamp_last_allocationprofile_gc_;
+  }
+
   intptr_t BlockClassFinalization() {
     ASSERT(defer_finalization_count_ >= 0);
     return defer_finalization_count_++;
   }
 
   intptr_t UnblockClassFinalization() {
     ASSERT(defer_finalization_count_ > 0);
     return defer_finalization_count_--;
   }
 
@@ skipping 122 matching lines @@
   bool is_runnable_;
   Dart_GcPrologueCallback gc_prologue_callback_;
   Dart_GcEpilogueCallback gc_epilogue_callback_;
   intptr_t defer_finalization_count_;
   DeoptContext* deopt_context_;
 
   // Status support.
   char* stacktrace_;
   intptr_t stack_frame_index_;
 
+  // Timestamps of last operation via service.

[koda, 2014/06/17 21:04:07]

Longer-term, I wish we had a different way of associating auxiliary info with an
isolate, rather than adding more fields.

[Cutch, 2014/06/18 14:35:04]

I had the same thought. Agreed.

+  int64_t timestamp_last_allocationprofile_accumulator_reset_;
+  int64_t timestamp_last_allocationprofile_gc_;
+
   bool cha_used_;
 
   // Ring buffer of objects assigned an id.
   ObjectIdRing* object_id_ring_;
 
   // Trace buffer support.
   TraceBuffer* trace_buffer_;
 
   IsolateProfilerData* profiler_data_;
   Mutex profiler_data_mutex_;
@@ skipping 140 matching lines @@
   char* script_url_;
   char* library_url_;
   char* class_name_;
   char* function_name_;
   char* exception_callback_name_;
 };
 
 }  // namespace dart
 
 #endif  // VM_ISOLATE_H_