Source/platform/PlatformInstrumentation.h - Issue 342513003: Don't allow direct const char* trace value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/PlatformInstrumentation.h

Issue 342513003: Don't allow direct const char* trace value (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Subset Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/PlatformInstrumentation.h

diff --git a/Source/platform/PlatformInstrumentation.h b/Source/platform/PlatformInstrumentation.h

index 4fe5087c4cc49d4f714ef1c5512d5e960b01d358..2397dfe4e6272e39145ad2a874456ba72402f204 100644

--- a/Source/platform/PlatformInstrumentation.h

+++ b/Source/platform/PlatformInstrumentation.h

@@ -89,7 +89,7 @@ private:

inline void PlatformInstrumentation::willDecodeImage(const String& imageType)

{

- TRACE_EVENT_BEGIN1(CategoryName, ImageDecodeEvent, ImageTypeArgument, TRACE_STR_COPY(imageType.ascii().data()));

+ TRACE_EVENT_BEGIN1(CategoryName, ImageDecodeEvent, ImageTypeArgument, imageType.ascii());

FAST_RETURN_IF_NO_CLIENT_OR_NOT_MAIN_THREAD();

m_client->willDecodeImage(imageType);

}

« no previous file with comments | « Source/core/frame/FrameView.cpp ('k') | Source/platform/TraceEvent.h » ('j') | no next file with comments »