Source/core/frame/FrameView.cpp - Issue 342513003: Don't allow direct const char* trace value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/FrameView.cpp

Issue 342513003: Don't allow direct const char* trace value (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Subset Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/frame/FrameView.cpp

diff --git a/Source/core/frame/FrameView.cpp b/Source/core/frame/FrameView.cpp

index e0214c1d30dfd7bd0035d2713f0f65bef932d115..38cd3201644bd61775cfad3862045141279a2f89 100644

--- a/Source/core/frame/FrameView.cpp

+++ b/Source/core/frame/FrameView.cpp

@@ -1053,7 +1053,7 @@ void FrameView::invalidateTree(RenderObject* root)

// we continue to track paint invalidation rects until this function is called.

ASSERT(!m_nestedLayoutCount);

- TRACE_EVENT1("blink", "FrameView::invalidateTree", "root", TRACE_STR_COPY(root->debugName().ascii().data()));

+ TRACE_EVENT1("blink", "FrameView::invalidateTree", "root", root->debugName().ascii());

// FIXME: really, we're in the paint invalidation phase here, and the compositing queries are legal.

// Until those states are fully fledged, I'll just disable the ASSERTS.

« no previous file with comments | « Source/bindings/v8/V8ScriptRunner.cpp ('k') | Source/platform/PlatformInstrumentation.h » ('j') | no next file with comments »