[DevTools] Ability to emulate touch or user agent, even when device emulation is turned off.

[DevTools] Ability to emulate touch or user agent, even when device emulation is turned off.

BUG=327641
R=pfeldman@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176330

[dgozman, 2014-06-17 11:25:51]

Take a look please.

[pfeldman, 2014-06-17 11:42:44]

https://codereview.chromium.org/342443002/diff/1/Source/devtools/front_end/el...
File Source/devtools/front_end/elements/OverridesView.js (right):

https://codereview.chromium.org/342443002/diff/1/Source/devtools/front_end/el...
Source/devtools/front_end/elements/OverridesView.js:97: if (settings[i]
instanceof WebInspector.Setting)
What else could it be?

https://codereview.chromium.org/342443002/diff/1/Source/devtools/front_end/el...
Source/devtools/front_end/elements/OverridesView.js:119: if (this._settings[i]
instanceof WebInspector.Setting) {
Lets not do this.

https://codereview.chromium.org/342443002/diff/1/Source/devtools/front_end/el...
Source/devtools/front_end/elements/OverridesView.js:334:
_updateUserAgentOnDeviceUserAgentChanged: function()
Looking at the code this belongs to the OverridesSupport

https://codereview.chromium.org/342443002/diff/1/Source/devtools/front_end/el...
Source/devtools/front_end/elements/OverridesView.js:347:
_setOverrideUserAgentEnabled: function(enabled)
ditto

[dgozman, 2014-06-17 12:02:20]

PTAL

https://codereview.chromium.org/342443002/diff/1/Source/devtools/front_end/el...
File Source/devtools/front_end/elements/OverridesView.js (right):

https://codereview.chromium.org/342443002/diff/1/Source/devtools/front_end/el...
Source/devtools/front_end/elements/OverridesView.js:119: if (this._settings[i]
instanceof WebInspector.Setting) {
On 2014/06/17 11:42:43, pfeldman wrote:
> Lets not do this.

Fixed.

https://codereview.chromium.org/342443002/diff/1/Source/devtools/front_end/el...
Source/devtools/front_end/elements/OverridesView.js:334:
_updateUserAgentOnDeviceUserAgentChanged: function()
On 2014/06/17 11:42:43, pfeldman wrote:
> Looking at the code this belongs to the OverridesSupport

Done.

https://codereview.chromium.org/342443002/diff/1/Source/devtools/front_end/el...
Source/devtools/front_end/elements/OverridesView.js:347:
_setOverrideUserAgentEnabled: function(enabled)
On 2014/06/17 11:42:43, pfeldman wrote:
> ditto

Done.

[pfeldman, 2014-06-17 12:03:26]

lgtm

[dgozman, 2014-06-17 12:03:46]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2014-06-17 12:04:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dgozman@chromium.org/342443002/20001

[commit-bot: I haz the power, 2014-06-17 13:52:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-17 13:52:24]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)

[dgozman, 2014-06-17 14:04:05]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2014-06-17 14:04:49]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dgozman@chromium.org/342443002/40001

[commit-bot: I haz the power, 2014-06-17 15:53:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-17 15:53:15]

Try jobs failed on following builders:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[dgozman, 2014-06-17 15:53:48]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2014-06-17 15:54:29]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dgozman@chromium.org/342443002/40001

[dgozman, 2014-06-17 16:03:56]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2014-06-17 16:04:05]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dgozman@chromium.org/342443002/60001

[commit-bot: I haz the power, 2014-06-17 16:04:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-17 16:04:23]

Failed to apply patch for Source/devtools/front_end/ui/SettingsUI.js:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/devtools/front_end/ui/SettingsUI.js
  Hunk #1 FAILED at 168.
  Hunk #2 succeeded at 185 (offset 2 lines).
  1 out of 2 hunks FAILED -- saving rejects to file
Source/devtools/front_end/ui/SettingsUI.js.rej

Patch:       Source/devtools/front_end/ui/SettingsUI.js
Index: Source/devtools/front_end/ui/SettingsUI.js
diff --git a/Source/devtools/front_end/ui/SettingsUI.js
b/Source/devtools/front_end/ui/SettingsUI.js
index
34e59af77c7ef6bb14cdbaa3d6db51499a5cf1cb..3a869a9f193d89f97041b05f012420c5338e58cd
100644
--- a/Source/devtools/front_end/ui/SettingsUI.js
+++ b/Source/devtools/front_end/ui/SettingsUI.js
@@ -168,10 +168,9 @@ WebInspector.SettingsUI.createSettingInputField =
function(label, setting, numer
  * @param {!WebInspector.Setting} setting
  * @param {number=} maxLength
  * @param {string=} width
- * @param {!WebInspector.Setting=} toggleSetting
  * @param {string=} defaultText
  */
-WebInspector.SettingsUI.createSettingLabel = function(label, setting,
maxLength, width, toggleSetting, defaultText)
+WebInspector.SettingsUI.createSettingLabel = function(label, setting,
maxLength, width, defaultText)
 {
     var p = document.createElement("p");
     var labelElement = p.createChild("span");
@@ -183,14 +182,12 @@ WebInspector.SettingsUI.createSettingLabel =
function(label, setting, maxLength,
     if (width)
         p.style.width = width;
 
-    if (toggleSetting)
-        toggleSetting.addChangeListener(onSettingChange);
     setting.addChangeListener(onSettingChange);
     onSettingChange();
 
     function onSettingChange()
     {
-        var text = toggleSetting && !toggleSetting.get() ? (defaultText || "")
: setting.get();
+        var text = setting.get() || defaultText;
         spanElement.title = text;
         if (maxLength && text.length > maxLength)
             text = text.substring(0, maxLength - 2) + "...";

[dgozman, 2014-06-17 16:26:14]

Committed patchset #5 manually as r176330 (presubmit successful).