Source/devtools/front_end/ResponsiveDesignView.js - Issue 342443002: [DevTools] Ability to emulate touch or user agent, even when device emulation is turned off.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/ResponsiveDesignView.js

Issue 342443002: [DevTools] Ability to emulate touch or user agent, even when device emulation is turned off. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: rebase Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/inspector-enabled/open-with-emulation-enabled.html ('k') | Source/devtools/front_end/elements/OverridesView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/ResponsiveDesignView.js

diff --git a/Source/devtools/front_end/ResponsiveDesignView.js b/Source/devtools/front_end/ResponsiveDesignView.js

index 701e92f34d9b970f508745768f8f85fa4fbd43c0..3fe398f6bc1a219cca0d4541379d60b2bf3e1e44 100644

--- a/Source/devtools/front_end/ResponsiveDesignView.js

+++ b/Source/devtools/front_end/ResponsiveDesignView.js

@@ -412,7 +412,8 @@ WebInspector.ResponsiveDesignView.prototype = {

// Touch and viewport.

this._touchSection = document.createElementWithClass("div", "responsive-design-section");

fieldsetElement = WebInspector.SettingsUI.createSettingFieldset(WebInspector.overridesSupport.settings.emulateDevice);

- fieldsetElement.appendChild(WebInspector.SettingsUI.createSettingCheckbox(WebInspector.UIString("Touch"), WebInspector.overridesSupport.settings.emulateTouchEvents, true));

+ if (!WebInspector.overridesSupport.hasTouchInputs())

+ fieldsetElement.appendChild(WebInspector.SettingsUI.createSettingCheckbox(WebInspector.UIString("Touch"), WebInspector.overridesSupport.settings.deviceTouch, true));

var viewportCheckbox = WebInspector.SettingsUI.createSettingCheckbox(WebInspector.UIString("Mobile"), WebInspector.overridesSupport.settings.emulateViewport, true);

viewportCheckbox.title = WebInspector.UIString("Enable meta viewport, overlay scrollbars and default 980px body width");

fieldsetElement.appendChild(viewportCheckbox);

@@ -425,7 +426,7 @@ WebInspector.ResponsiveDesignView.prototype = {

this._networkSection.appendChild(WebInspector.overridesSupport.createNetworkThroughputSelect(document));

this._userAgentSection = document.createElementWithClass("div", "responsive-design-section responsive-design-user-agent-section");

- this._userAgentSection.appendChild(WebInspector.SettingsUI.createSettingLabel(WebInspector.UIString("User Agent:"), WebInspector.overridesSupport.settings.userAgent, 25, "200px", WebInspector.overridesSupport.settings.overrideUserAgent, WebInspector.UIString("no override")));

+ this._userAgentSection.appendChild(WebInspector.SettingsUI.createSettingLabel(WebInspector.UIString("User Agent:"), WebInspector.overridesSupport.settings.deviceUserAgent, 25, "200px", WebInspector.UIString("no override")));

updateNetworkCheckboxTitle();

WebInspector.overridesSupport.settings.networkConditionsDomains.addChangeListener(updateNetworkCheckboxTitle);