Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 342433002: DevTools: cleanup Network.emulateNetworkConditions (Closed)

Created:
6 years, 6 months ago by eustas
Modified:
6 years, 6 months ago
Reviewers:
vsevik, dgozman, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

DevTools: cleanup Network.emulateNetworkConditions WARNING: should be landed after corresponding chromium patch. BUG=245436 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176504

Patch Set 1 #

Patch Set 2 : Do not pass client id #

Patch Set 3 : Do not add headers in blink #

Patch Set 4 : Rebased #

Patch Set 5 : Remove domains field #

Patch Set 6 : Rebase #

Patch Set 7 : Rebase #

Patch Set 8 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -43 lines) Patch
M Source/devtools/front_end/ResponsiveDesignView.js View 1 2 3 4 5 6 7 1 chunk +0 lines, -16 lines 0 comments Download
M Source/devtools/front_end/elements/OverridesView.js View 1 2 3 4 5 6 1 chunk +0 lines, -3 lines 0 comments Download
M Source/devtools/front_end/sdk/OverridesSupport.js View 1 2 3 4 5 6 7 4 chunks +2 lines, -22 lines 0 comments Download
M Source/devtools/protocol.json View 1 2 3 4 5 6 7 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
eustas
Please consider preliminary review.
6 years, 6 months ago (2014-06-17 09:23:22 UTC) #1
eustas
6 years, 6 months ago (2014-06-17 16:49:45 UTC) #2
dgozman
lgtm
6 years, 6 months ago (2014-06-17 19:26:38 UTC) #3
vsevik
lgtm
6 years, 6 months ago (2014-06-18 09:05:59 UTC) #4
eustas
The CQ bit was checked by eustas@chromium.org
6 years, 6 months ago (2014-06-19 08:23:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/342433002/140001
6 years, 6 months ago (2014-06-19 08:24:36 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-19 10:37:19 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/19135)
6 years, 6 months ago (2014-06-19 10:37:20 UTC) #8
eustas
The CQ bit was checked by eustas@chromium.org
6 years, 6 months ago (2014-06-19 11:04:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/342433002/140001
6 years, 6 months ago (2014-06-19 11:04:39 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 11:59:01 UTC) #11
Message was sent while issue was closed. 
Change committed as 176504

Powered by Google App Engine
This is Rietveld 408576698